Bugzilla – Full Text Bug Listing
| Summary: | AbstractContentPart#reorderContentChild always fails | ||
|---|---|---|---|
| Product: | [Tools] GEF | Reporter: | David Dubrow <ddubrow> |
| Component: | GEF MVC | Assignee: | gef-inbox <gef-inbox> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | major | ||
| Priority: | P3 | CC: | matthias.wienand, miklossy |
| Version: | unspecified | ||
| Target Milestone: | 5.0.1 (Oxygen.1) M1 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | |||
Thank you for the bug report! I fixed the issue by negating the condition (according to your suggestion). The changes are published on the origin/R5_0_0_maintenance and origin/master branches. Therefore, I resolve this ticket as fixed for Oxygen.1 (the target milestone still needs to be added). [519308] Fix guard within reorderContentChild. - Reordering could not have worked with the faulty guard as it throws an error when the given content object is a content child. - This fix negates the condition. - Moreover, the error messages are enhanced, using "it is" instead of "its". - The versions of all related projects have been incremented to 5.0.1. |
if (oldContentChildren.contains(contentChild)) { throw new IllegalArgumentException("Cannot reorder " + contentChild + " because its not a content child."); } The above check will cause all valid cases to fail. Should be: if (!oldContentChildren.contains(contentChild)...