Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 519295

Summary: [GTK3] Invisible settings button in validation preferences
Product: [Eclipse Project] Platform Reporter: István Tóth <stoty>
Component: SWTAssignee: Eric Williams <ericwill>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ericwill, loskutov, lufimtse
Version: 4.7Keywords: triaged
Target Milestone: 4.7.3   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/115130
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=458bdeadd04cc1a45cff6a7f661fe5d0279fb6fb
https://git.eclipse.org/r/115131
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=dbf306e169f35af8aa89ffba3749d703dd45a450
https://git.eclipse.org/r/115151
https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4d3e9a159f1a3b267d2c2a7bac7b84f67a51f26b
Whiteboard:
Attachments:
Description Flags
validation screen with GTK3
none
Validation screen with GTK2 (correct)
none
The output of the configuration screen from installation details none

Description István Tóth CLA 2017-07-06 07:07:55 EDT
Created attachment 269241 [details]
validation screen with GTK3

When I start eclipse without SWT_GTK3="1", the settings button is invisible on the validation screen.

If you can figure out where it is, you can click it, and it works.

My system is Centos 7 x86_66 with all the latest fixes.

The gtk3 package is
gtk3-3.14.13-20.el7_3.1.x86_64

I am using the default gnome clasic desktop with the default theme (have not found a way to switch themes)
Comment 1 István Tóth CLA 2017-07-06 07:08:37 EDT
Created attachment 269242 [details]
Validation screen with GTK2 (correct)
Comment 2 Eric Williams CLA 2017-07-06 09:57:09 EDT
Hi, what build of Eclipse does this occur with?
Comment 3 István Tóth CLA 2017-07-06 10:16:03 EDT
The 4.7.0 x86_64 release build.

Version: Oxygen Release (4.7.0)
Build id: 20170620-1800

I have also added updates from the http://download.eclipse.org/eclipse/updates/4.7-M-builds/

site, but those did not seem to touch swt, and did not solve the problem.
Comment 4 István Tóth CLA 2017-07-06 10:17:23 EDT
Created attachment 269257 [details]
The output of the configuration screen from installation details

I have also added the long config output
Comment 5 Leo Ufimtsev CLA 2017-07-06 13:54:31 EDT
Do you know what contributes the "Validation" setting in the preference? It doesn't come in a vanilla eclipse. Looks like some plugin contributed it.
Comment 6 István Tóth CLA 2017-07-06 16:42:39 EDT
It's irrelevant, the problem is not specific to that validator.

A lot of validators have identical settings buttons, and none of them are visible with GTK3, it's just that the window is set too small to show the rest of the validators with settings buttons in the GTK2 shot.

Again, the buttons are clickable, even though they are not visible.
Comment 7 István Tóth CLA 2017-07-06 16:56:56 EDT
The validation screen itself has always been present in preferences window, as far as I can remember, at least in the java ee bundles.
Comment 8 István Tóth CLA 2018-01-05 08:34:59 EST
Problem persists in 4.7.2 on fully updated Centos 7 machine.
Comment 9 Eclipse Genie CLA 2018-01-09 14:58:29 EST
New Gerrit change created: https://git.eclipse.org/r/115130
Comment 11 Eclipse Genie CLA 2018-01-09 16:08:18 EST
New Gerrit change created: https://git.eclipse.org/r/115131
Comment 13 Eric Williams CLA 2018-01-09 16:17:33 EST
(In reply to Eclipse Genie from comment #10)
> Gerrit change https://git.eclipse.org/r/115130 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=458bdeadd04cc1a45cff6a7f661fe5d0279fb6fb

Patch is in master.

(In reply to Eclipse Genie from comment #12)
> Gerrit change https://git.eclipse.org/r/115131 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=dbf306e169f35af8aa89ffba3749d703dd45a450

Bug snippet has been merged as well.
Comment 14 Eclipse Genie CLA 2018-01-10 03:46:47 EST
New Gerrit change created: https://git.eclipse.org/r/115151
Comment 15 Andrey Loskutov CLA 2018-01-10 03:51:48 EST
Backport patch for 4.7.3: https://git.eclipse.org/r/#/c/115151/
Comment 17 Eric Williams CLA 2018-01-10 09:12:24 EST
(In reply to Eclipse Genie from comment #16)
> Gerrit change https://git.eclipse.org/r/115151 was merged to
> [R4_7_maintenance].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=4d3e9a159f1a3b267d2c2a7bac7b84f67a51f26b

Patch backported.
Comment 18 Eric Williams CLA 2018-02-15 11:35:21 EST
Verified in M20180214-1700.