Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518871

Summary:

Wrong first or last GMF bendpoints in case of Straight routing style with only one segment

Product:

[Modeling] Sirius

Reporter:

Laurent Redor <laurent.redor>

Component:

Diagram

Assignee:

Laurent Redor <laurent.redor>

Status:

CLOSED FIXED

QA Contact:

Julien Dupont <julien.dupont>

Severity:

normal

Priority:

CC:

julien.dupont, pierre-charles.david

Version:

3.1.0

Keywords:

triaged

Target Milestone:

5.1.0

Hardware:

All

OS:

All

See Also:

https://git.eclipse.org/r/100601
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=103582118a902caa5867b27ed76d2f07d933ca7c

Whiteboard:

Bug Depends on:

518073

Bug Blocks:

517437, 518440, 518441, 518870

Attachments:

Description	Flags
Use case to reproduce	none

Description Laurent Redor

2017-06-28 04:46:42 EDT

+++ This bug was initially created as a clone of Bug #518073 +++

In case of an edge with a Straight routing style and with only one segment, the GMF bendpoints are false if the edge is "reverted". For example, in the case of "1-beforeMovingEdge.png", the GMF bendpoints are correct (same as draw2d). But if the node C2 is moved on left of C1, the GMF bendpoints are wrong (see "2-afterMovingEdge.png").
These false bendpoints can be problematic for other calculations (like label location).

Steps to reproduce:
* Open the diagram "newDiag3" of the project "SampleProject" (from SampleProject.zip)
* Open the "Sirius Debugging View" (from plugin org.eclipse.sirius.ui.debug)
* Select the edge between C1 and C2
* In the "Sirius Debugging View", the GMF computed points are the same as Draw2D points.
* Move C2 to the left of C1
* KO: In the "Sirius Debugging View", the GMF computed points are not the same as Draw2D points.

Comment 1 Eclipse Genie

2017-07-04 04:34:42 EDT

New Gerrit change created: https://git.eclipse.org/r/100601

Comment 2 Eclipse Genie

2017-07-06 05:59:08 EDT

Gerrit change https://git.eclipse.org/r/100601 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=103582118a902caa5867b27ed76d2f07d933ca7c

Comment 3 Julien Dupont

2017-09-20 06:06:33 EDT

Created attachment 270272 [details]
Use case to reproduce

To validate it, put plugins directory in droppins directory

Comment 4 Pierre-Charles David

2017-11-08 03:36:37 EST

Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.