Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518862

Summary: Bad Array.find usage in setup.js
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: ClientAssignee: Casey Flynn <caseyflynn>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3    
Version: 14.0   
Target Milestone: 16.0   
Hardware: PC   
OS: Mac OS X   
See Also: https://github.com/eclipse/orion.client/pull/107
Whiteboard:

Description Michael Rennie CLA 2017-06-27 20:58:03 EDT
I happened to be looking for something in setup.js and noticed the lint warnings that find is undefined in Array (since our ECMA level is 5 in Orion).

one is on line 968:

Array.prototype.find.call(  //for some reason this one was not marked

the other is on line 625:

this.fileList.find(

https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/find#Browser_compatibility
Comment 1 Michael Rennie CLA 2017-06-27 21:01:51 EDT
I opened bug 518863 to report the fact that the Array.prototype.find.call was not flagged as not being part of array
Comment 2 Eclipse Genie CLA 2017-07-10 12:05:01 EDT
GitHub Pull Request 107 created by [caseyflynn-google]
https://github.com/eclipse/orion.client/pull/107