Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518735

Summary:	[lsp] textDocument/didSave notifications are being sent early
Product:	[ECD] Orion	Reporter:	Remy Suen <remy.suen>
Component:	Client	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Olivier_Thomann
Version:	unspecified
Target Milestone:	15.0
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2017-06-23 17:16:45 EDT

The current code sends the textDocument/didSave event before the document has actually been written on the server. We should only send this notification after the server comes back with a successful response for the file write request.

Comment 1 Remy Suen

2017-06-23 18:11:35 EDT

Fix pushed to the java-lsp branch. I also added code to include the text of the saved document in the response if the server asked for it in its initial ServerCapabilities response.

https://github.com/eclipse/orion.client/commit/9963215985eed6cc0561000a9192422bf8b1f848