Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518685

Summary:	[lsp] Orion assumes that textDocument/completion requests will always return a CompletionList
Product:	[ECD] Orion	Reporter:	Remy Suen <remy.suen>
Component:	Client	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Olivier_Thomann
Version:	unspecified
Target Milestone:	15.0
Hardware:	All
OS:	All
Whiteboard:

Description Remy Suen

2017-06-23 05:49:34 EDT

/**
 * Represents a collection of [completion items](#CompletionItem) to be presented
 * in the editor.
 */
interface CompletionList {
	/**
	 * This list it not complete. Further typing should result in recomputing
	 * this list.
	 */
	isIncomplete: boolean;
	/**
	 * The completion items.
	 */
	items: CompletionItem[];
}

In response to a 'textDocument/completion' request, servers may may return a CompletionItem[] or a CompletionList. However, Orion assumes that a CompletionList will be returned and immediately uses the returned result's (potentially undefined) items property for the content assist proposals.

https://github.com/eclipse/orion.client/blob/7916a21160acc4271af1ea25b06575f804a7708a/bundles/org.eclipse.orion.client.ui/web/orion/lsp/utils.js#L243-L245

Comment 1 Remy Suen

2017-06-23 05:54:05 EDT

Fix pushed to the java-lsp branch.

https://github.com/eclipse/orion.client/commit/d2d8a947c9afded2ae4c56c8442f810a90bb49fb