Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518651

Summary: "Rectilinear" Line style Sirius preference does not work correctly.
Product: [Modeling] Sirius Reporter: Jessy Mallet <jessy.mallet>
Component: DiagramAssignee: Jessy Mallet <jessy.mallet>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: normal    
Priority: P3 CC: julien.dupont, laurent.redor
Version: 5.0.0Keywords: triaged
Target Milestone: 5.1.0   
Hardware: PC   
OS: Windows NT   
See Also: https://git.eclipse.org/r/99896
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b6d7191463b338113b59495b568161bb0120baf3
Whiteboard:
Attachments:
Description Flags
Test case to use in order to reproduce error.
none
Result Ko none

Description Jessy Mallet CLA 2017-06-22 12:20:23 EDT
When user set "Rectilinear" Line style Sirius preference, for new horizontal or vertical edges (even with border nodes), the created rectilinear edge is very huge  (not horizontal or vertical as expected) and include some useless bendpoints.
Comment 1 Jessy Mallet CLA 2017-06-22 12:30:54 EDT
Created attachment 269026 [details]
Test case to use in order to reproduce error.
Comment 2 Jessy Mallet CLA 2017-06-22 12:36:39 EDT
Step to reproduce :

* import in your workspace the modeling project RectilinearEdgeCreation.zip,
* open diagrams "new Container",
* Set preference "Sirius/Sirius Diagram/Connections/Enable user specific values" to true and choose "Rectilinear" as Line style,
* create an horizontal edge between A and B using tool "SuperWithBorderNode"
  for the creation, choose the bottom right of A class as source and the bottom left for the target,
* The new edge between the 2 new border nodes is not straight but has strange bendpoints: KO.
  The new edge should be strainght with only two bendpoints (source and target)
Comment 3 Eclipse Genie CLA 2017-06-22 12:48:06 EDT
New Gerrit change created: https://git.eclipse.org/r/99896
Comment 4 Julien Dupont CLA 2017-06-23 11:18:17 EDT
Created attachment 269042 [details]
Result Ko
Comment 6 Pierre-Charles David CLA 2017-11-08 03:37:13 EST
Available in Sirius 5.1.0, see https://wiki.eclipse.org/Sirius/5.1.0.