Bug 518623

Description Remy Suen 2017-06-22 05:47:43 EDT

7b70330e201f86ba33a586c4c6e9f7871a9e8308

1. Connect Orion to a language server that doesn't support trigger characters for code completion.
2. Open the file and try to edit it.
3. Errors will be logged.

/**
 * Completion options.
 */
export interface CompletionOptions {
	/**
	 * The server provides support to resolve additional
	 * information for a completion item.
	 */
	resolveProvider?: boolean;

	/**
	 * The characters that trigger completion automatically.
	 */
	triggerCharacters?: string[];
}

According to the spec, triggerCharacters is an optional attribute so we shouldn't try to arbitrarily read it without first checking that it exists.

contentAssist.js:750 Uncaught TypeError: Cannot read property 'forEach' of undefined
    at ContentAssist.<anonymous> (http://localhost:8081/orion/editor/contentAssist.js:750:43)
    at Array.forEach (native)
    at ContentAssist._triggerListener (http://localhost:8081/orion/editor/contentAssist.js:737:21)
    at TextView._dispatchEvent (http://localhost:8081/orion/editor/eventTarget.js:82:12)
    at TextView.dispatchEvent (http://localhost:8081/orion/editor/eventTarget.js:62:9)
    at TextView.onModify (http://localhost:8081/orion/editor/textView.js:2759:16)
    at TextView._modifyContent (http://localhost:8081/orion/editor/textView.js:6632:9)
    at TextView._doContent (http://localhost:8081/orion/editor/textView.js:4917:16)
    at TextView._handleKeyPress (http://localhost:8081/orion/editor/textView.js:3924:11)
    at HTMLDivElement.handler (http://localhost:8081/orion/editor/textView.js:6375:91)