Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518591

Summary:	Git Log broken for /modules/orionode/lib/git/tree.js file
Product:	[ECD] Orion	Reporter:	XinYi Jiang <xinyij>
Component:	Node	Assignee:	Remy Suen <remy.suen>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3
Version:	14.0
Target Milestone:	15.0
Hardware:	All
OS:	All
Whiteboard:

Description XinYi Jiang

2017-06-21 14:42:38 EDT

open that file, make sure you are in master branch. Then do View-> open related -> git Log.
the result has only one commit. which is wrong.

Comment 1 Remy Suen

2017-06-21 16:30:18 EDT

Seems the filtering code is causing a branch to be completely ignored.

Comment 2 XinYi Jiang

2017-06-21 22:15:47 EDT

(In reply to Remy Suen from comment #1)
> Seems the filtering code is causing a branch to be completely ignored.
can you fix this please. I have no idea how the code works now, the core part are pretty much all your changes.

Comment 3 Remy Suen

2017-06-22 04:44:55 EDT

(In reply to XinYi Jiang from comment #2)
> can you fix this please

Your wish is my command. The fix has been pushed to master.

https://github.com/eclipse/orion.client/commit/2962df64580a572fbd4fa2537fc30e6b383c25c2

In all seriousness, I was planning to fix this anyway (as I didn't change the assignee >:)). Thanks for the bug report, Sidney! :D