Bugzilla – Full Text Bug Listing
|
Description
Lakshmi P Shanmugam
New Gerrit change created: https://git.eclipse.org/r/99830 Gerrit change https://git.eclipse.org/r/99830 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=6ce6e56eb49a6aa3a12ce2140a0f645922afb108 The above commit deprecates SWT.MOZILLA and Browser.getWebBrowser(). SWT.MOZILLA style will be ignored and code will fallback to using default browser (SWT.NONE style) if SWT.WEBKIT is not specified. New Gerrit change created: https://git.eclipse.org/r/99894 Gerrit change https://git.eclipse.org/r/99894 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c066068b7af86eead3d8038f9c5eff5eec4c55a7 Found that we can't remove the code entirely from Mozilla source folder now. The org.eclipse.swt.internal.mozilla package is exported by fragments and all the classes in the package have APIs. So, I plan to deprecate the package using package-info.java file. Also, removing org.eclipse.swt.browser from the Mozilla source folder causes API tools error on Mac. It doesn't have API but the package is exported. Will verify this again. New Gerrit change created: https://git.eclipse.org/r/100030 Gerrit change https://git.eclipse.org/r/100030 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=16ccb324f949ee915ca80a80cba992d5d1dc7eb0 (In reply to Lakshmi Shanmugam from comment #6) > Found that we can't remove the code entirely from Mozilla source folder now. > The org.eclipse.swt.internal.mozilla package is exported by fragments and > all the classes in the package have APIs. So, I plan to deprecate the > package using package-info.java file. > Also, removing org.eclipse.swt.browser from the Mozilla source folder causes > API tools error on Mac. It doesn't have API but the package is exported. > Will verify this again. It's internal package so I don't see an issue with removing it ? Further more keeping the java code without so files looks really weird. Looking more into the o.e.swt.browser classes in Mozilla dir - all of them are package private so I don't see how this can be considered API breakage. What is the API tool error you see? (In reply to Alexander Kurtakov from comment #10) > Looking more into the o.e.swt.browser classes in Mozilla dir - all of them > are package private so I don't see how this can be considered API breakage. > What is the API tool error you see? I verified this in another workspace. Removing the o.e.swt.browser package in the Mozilla source folder gives me this API Tools error-> The major version should be incremented in version 3.106.100, since API breakage occurred since version 3.106.0. If I remove all the content from the package, but leave the empty package, I don't get the error. (In reply to Lakshmi Shanmugam from comment #11) > (In reply to Alexander Kurtakov from comment #10) > > Looking more into the o.e.swt.browser classes in Mozilla dir - all of them > > are package private so I don't see how this can be considered API breakage. > > What is the API tool error you see? > > I verified this in another workspace. Removing the o.e.swt.browser package > in the Mozilla source folder gives me this API Tools error-> The major > version should be incremented in version 3.106.100, since API breakage > occurred since version 3.106.0. > If I remove all the content from the package, but leave the empty package, I > don't get the error. This is really weird. o.e.swt.browser has common content that lives outside of Mozilla implementation (Progress, StatusText, Title and etc. listeners) so this package wouldn't be empty after removing the mozilla code. Do you want me to propose a patch here so we can speak over smth real? New Gerrit change created: https://git.eclipse.org/r/100108 Gerrit change https://git.eclipse.org/r/100108 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=32c670eab330a7b35bc6f5a678c799c6fc849ec5 New Gerrit change created: https://git.eclipse.org/r/100120 New Gerrit change created: https://git.eclipse.org/r/100121 Lakshmi, with the 2 patches I don't see any warnings/errors. If there are still some API warnings I propose adding filters for them as we are not removing any API here. Gerrit change https://git.eclipse.org/r/100120 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=c7873a6d67287d549d73d2bb69b08a1385cd0784 Gerrit change https://git.eclipse.org/r/100121 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?id=ced97010eb138670ab61ab535adfb68fa5e8ec01 (In reply to Alexander Kurtakov from comment #17) > Lakshmi, with the 2 patches I don't see any warnings/errors. If there are > still some API warnings I propose adding filters for them as we are not > removing any API here. Thanks for the patches, Alex. I had made similar changes and applying your patch too gave me the same API tool errors. After some debugging found that the problems were caused by the SWT tools installed in my Eclipse. Uninstalling it & installing the latest fixed the problems for me. New Gerrit change created: https://git.eclipse.org/r/100314 (In reply to Lakshmi Shanmugam from comment #20) > (In reply to Alexander Kurtakov from comment #17) > > Lakshmi, with the 2 patches I don't see any warnings/errors. If there are > > still some API warnings I propose adding filters for them as we are not > > removing any API here. > > Thanks for the patches, Alex. I had made similar changes and applying your > patch too gave me the same API tool errors. After some debugging found that > the problems were caused by the SWT tools installed in my Eclipse. > Uninstalling it & installing the latest fixed the problems for me. Ah, yes. In one of the previous patches I fixed swt.tools to not look for mozilla stuff anymore :). Gerrit change https://git.eclipse.org/r/100314 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=18326ae5bb99e1bc2fe12f7d3b1b1b678c9b97b5 Hello guys, I haven't been keeping track of things, but something that came to my attention is that now on my Win10 VM, the MANIFEST.MF of org.eclipse.swt.win32.win32.x86_64 [in swt.binaries git] is complaining that package: org.eclipse.swt.internal.mozilla; does not exist in this plug-in (in the list of exported packages). If I delete the export from the MANIFEST.MF, the error goes away. Can we remove the package from MANIFEST.MF? New Gerrit change created: https://git.eclipse.org/r/100429 New Gerrit change created: https://git.eclipse.org/r/100430 (In reply to Leo Ufimtsev from comment #24) > Hello guys, > > > I haven't been keeping track of things, but something that came to my > attention is that now on my Win10 VM, the MANIFEST.MF of > org.eclipse.swt.win32.win32.x86_64 [in swt.binaries git] > is complaining that package: > org.eclipse.swt.internal.mozilla; > does not exist in this plug-in (in the list of exported packages). > > If I delete the export from the MANIFEST.MF, the error goes away. > > Can we remove the package from MANIFEST.MF? Thanks for pointing it out, fixed via --> http://git.eclipse.org/c/platform/eclipse.platform.swt.binaries.git/commit/?id=9f834a6dd55e57be67e63369e19547f99b34ec44 Gerrit change https://git.eclipse.org/r/100430 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/swt.git/commit/?id=cc26a81cb65b6e8e1ef17258d890a7016732bed9 (In reply to Lakshmi Shanmugam from comment #27) > Thanks for pointing it out, fixed via --> thnx dude. Marking this one as resolved as all mozilla code is gone from the swt repo. *** Bug 380867 has been marked as a duplicate of this bug. *** |