Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518468

Summary:	Cache-Control header not set properly
Product:	[ECD] Orion	Reporter:	Silenio Quarti <Silenio_Quarti>
Component:	Server	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	grant_gayed, Michael_Rennie
Version:	unspecified	Flags:	grant_gayed: review+
Target Milestone:	15.0
Hardware:	PC
OS:	Mac OS X
See Also:	https://github.com/eclipse/orion.server/pull/5
Whiteboard:

Description Silenio Quarti

2017-06-19 10:47:41 EDT

In OrionSerlet#writeResponse, we call

	resp.setHeader("Cache-Control", "no-cache"); //$NON-NLS-1$ //$NON-NLS-2$
	resp.setHeader("Cache-Control", "no-store"); //$NON-NLS-1$ //$NON-NLS-2$

this sets the Cache-Control to "no-store", because the second line overwrites the first one.

Comment 1 Eclipse Genie

2017-06-19 10:53:36 EDT

GitHub Pull Request 5 created by [squarti]
https://github.com/eclipse/orion.server/pull/5

Comment 2 Silenio Quarti

2017-06-19 11:03:04 EDT

Merged