Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 518009

Summary: [aird editor] elements inside a disabled viewpoint should appear disabled (in grey)
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: CoreAssignee: Project inbox <sirius.core-inbox>
Status: CLOSED FIXED QA Contact: Julien Dupont <julien.dupont>
Severity: enhancement    
Priority: P3 CC: julien.dupont, pierre.guilet
Version: 5.0.0Keywords: triaged
Target Milestone: 5.0.1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/99601
https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=966ba9683d6c921b5f521349b7299bf49bdc1b16
Whiteboard: aird_editor ux

Description Pierre-Charles David CLA 2017-06-08 10:21:49 EDT
Currently, in the aird editor's graphical block, disabled viewpoints appear in grey (when they are not filtered). However the elements inside them (representation types and representation instances) are in "normal" style.

This was an explicit choice, as even if the viewpoint is disabled we allow users to create new representations and open existing ones directly (Sirius will simply enable the required viewpoint automatically in this case). However, after seeing it in action, it looks rather inconsistent graphicaly, and make it more difficult to see the full side-effect of automatic viewpoint enablement (especially when viewpoints are filtered!). In addition, it is also inconsistent with the "Model Explorer", where representations types/instances from disabled viewpoint are simply not visible.

We should probably make these elements look disabled graphically, as their parent viewpoint is. It's still inconsistent, in a different way, because normally disabled elements are not "actionable", but it seems the least wrong alternative (unless another one is found).
Comment 1 Pierre-Charles David CLA 2017-06-14 09:43:32 EDT
Putting in 5.0.1 if possible, but may shift to 5.1.
Comment 2 Eclipse Genie CLA 2017-06-19 11:08:10 EDT
New Gerrit change created: https://git.eclipse.org/r/99601
Comment 4 Pierre-Charles David CLA 2017-06-30 09:46:24 EDT
Available in Sirius 5.0.1, see https://wiki.eclipse.org/Sirius/5.0.1 for details.