Bugzilla – Full Text Bug Listing
| Summary: | [aird editor] change icons for representation descriptions to better distinguish those from representation | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Modeling] Sirius | Reporter: | Pierre Guilet <pierre.guilet> | ||||
| Component: | Core | Assignee: | Pierre-Charles David <pierre-charles.david> | ||||
| Status: | CLOSED FIXED | QA Contact: | Julien Dupont <julien.dupont> | ||||
| Severity: | enhancement | ||||||
| Priority: | P3 | CC: | julien.dupont, pierre-charles.david | ||||
| Version: | unspecified | Keywords: | triaged | ||||
| Target Milestone: | 5.0.1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/99861 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d1e44ecd3c1e273c5fe3c25c4c51fce8c989456e https://git.eclipse.org/r/100138 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d669d316dd3edd9a65b98b609d331b4a5b6e67ce https://git.eclipse.org/r/100185 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e40d3480ca0fc64724032b60414ff92d3e9fa46a |
||||||
| Whiteboard: | aird_editor ui icons model_explorer | ||||||
| Attachments: |
|
||||||
|
Description
Pierre Guilet
Created attachment 268818 [details]
Proposed icons
Note that this is not as trivial as is sounds, as the current code (see org.eclipse.sirius.ui.tools.internal.views.common.navigator.SiriusCommonLabelProvider.getImage(Object)) explicitly uses the a representation's *description* icon instead of the representation instance's one. There are reasons for doing so, related to the label provider being in a core plug-in while the icons are defined in the dialect-specific metamodels/plug-ins. I don't remember the details right now, but Maxime knows about them. Changing this behavior in the SiriusCommonLabelProvider will also change it in the model explorer and in all other places where CNF displays Sirius session elements. New Gerrit change created: https://git.eclipse.org/r/99861 Gerrit change https://git.eclipse.org/r/99861 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d1e44ecd3c1e273c5fe3c25c4c51fce8c989456e Fixed by d1e44ecd3c1e273c5fe3c25c4c51fce8c989456e. We'll need to update the screenshots, but otherwise we're done. New Gerrit change created: https://git.eclipse.org/r/100138 Gerrit change https://git.eclipse.org/r/100138 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=d669d316dd3edd9a65b98b609d331b4a5b6e67ce New Gerrit change created: https://git.eclipse.org/r/100185 Gerrit change https://git.eclipse.org/r/100185 was merged to [master]. Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=e40d3480ca0fc64724032b60414ff92d3e9fa46a Available in Sirius 5.0.1, see https://wiki.eclipse.org/Sirius/5.0.1 for details. |