Bugzilla – Full Text Bug Listing
|
Description
Lars Vogel
(In reply to Lars Vogel from comment #0) > SWT.ICON_SEARCH looks every ugly under Linux, looks beautiful under Mac OS. Can you attach screenshots? SWT uses these icons as supplied by the underlying OS and windowing system, so this would be a platform limitation IMO. Olivier, can you upload the MAC icon? Created attachment 268658 [details]
Screenshot
Created attachment 268659 [details]
Mac screenshot
Here it is
New Gerrit change created: https://git.eclipse.org/r/98352 Created attachment 268671 [details]
Before(left) and after(right) patch
> SWT.ICON_SEARCH looks every ugly under Linux, looks beautiful under Mac OS. > > Can we change the usage icon? Yea: > New Gerrit change created: https://git.eclipse.org/r/98352 We are using system icons and not our own. However, the system has 'symbolic' versions of all icons, which look more like the mac equivalent. Actually, the other icons were already symbolic, only the search icons were traditional. So I submitted a patch to use symbolic icons instead. See attached screenshot. We'll have to wait for code unfreeze before merging. Looks awesome, Leo. Thanks. (In reply to Leo Ufimtsev from comment #7) > We are using system icons and not our own. > However, the system has 'symbolic' versions of all icons, which look more > like the mac equivalent. > Actually, the other icons were already symbolic, only the search icons were > traditional. So I submitted a patch to use symbolic icons instead. See > attached screenshot. Good find Leo! Leo, what about using https://developer.gnome.org/gtk3/stable/GtkSearchEntry.html ? It should simplify our code significantly. Leo, if you think it can work that way please handle it in separate bug. (In reply to Alexander Kurtakov from comment #10) > Leo, what about using > https://developer.gnome.org/gtk3/stable/GtkSearchEntry.html ? It should > simplify our code significantly. (In reply to Alexander Kurtakov from comment #11) > Leo, if you think it can work that way please handle it in separate bug. Indeed, good idea. Would require some work. Created followup bug: Bug 518080 – Use GtkSearchEntry instead of gtkEntry + icon Gerrit change https://git.eclipse.org/r/98352 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=060443c93dd7d07200925e17ed604990033643ab Leo, I suggest to downport this to 4.7.1. WDYT? New Gerrit change created: https://git.eclipse.org/r/99140 Gerrit change https://git.eclipse.org/r/99140 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a8056906b41eb2845e36ea4b962b1544448ce563 (In reply to Lars Vogel from comment #14) > Leo, I suggest to downport this to 4.7.1. WDYT? Done. Thanks. (In reply to Leo Ufimtsev from comment #17) > Done. Thanks. Thanks. But I think you need to revert this and wait a bit longer. 4.7.1 will be opened after the 4.7.0 release. Reopening for the downport New Gerrit change created: https://git.eclipse.org/r/99154 Gerrit change https://git.eclipse.org/r/99154 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=982b35c1b0de3192655e62e5118ad045ab1efd5b (In reply to Lars Vogel from comment #18) > (In reply to Leo Ufimtsev from comment #17) > > Done. Thanks. > > Thanks. But I think you need to revert this and wait a bit longer. 4.7.1 > will be opened after the 4.7.0 release. Oh, I see. I thought since the 4_7 branch was created, it could be merged into. I've reverted for now, awaiting 4.7.0 release. (In reply to Leo Ufimtsev from comment #22) > I've reverted for now, awaiting 4.7.0 release. We could do the downport now. New Gerrit change created: https://git.eclipse.org/r/101369 Gerrit change https://git.eclipse.org/r/101369 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=93fd1b94b4114f839a01942bd3807b123f978560 (In reply to Lars Vogel from comment #23) > (In reply to Leo Ufimtsev from comment #22) > > I've reverted for now, awaiting 4.7.0 release. > > We could do the downport now. Thank you. Done. I'm lagging behind with my backports X-D. I'll try to finish outstanding backports this week-ish. (In reply to Leo Ufimtsev from comment #26) > I'm lagging behind with my backports X-D. I'll try to finish outstanding > backports this week-ish. Thanks. FYI - If that commit was the first one for the plug-in in the maintenance branch, you also need to increase the patch version (major.minor.patch.buildqualifier) by "1" in the MANIFEST.MF and pom.xml of that plug-in. See https://wiki.eclipse.org/Version_Numbering New Gerrit change created: https://git.eclipse.org/r/101441 (In reply to Eclipse Genie from comment #28) > New Gerrit change created: https://git.eclipse.org/r/101441 Ah, I see. Thanks for pointing out. Is this correct? Gerrit change https://git.eclipse.org/r/101441 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=739ae1e9449d73fefaa99f0a8caabc5cb1e7d419 |