Created attachment 268631 [details]
Illustrative image
New Gerrit change created: https://git.eclipse.org/r/98205 I proposed a patch to solve this problem. If the topic references a html, we keep the same behavior, which generates a href towards section + id. Otherwise, if the topic references an anchor, the generated href should point towards the anchor's id. Would you mind having a look at it ? Gerrit change https://git.eclipse.org/r/98205 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=8e2fe1ac6f6539f86e99f5b936d68f2bac3a2da4 Thanks for the nice patch. It's pushed to master now and will be in the next release. And sorry for the delay, we have missed it in the churn surrounding the current release. Thanks for the review. Just a small question, could I do a cherrypick to the branch 4.7 so that we can have the fix earlier in Eclipse Oxygen ? Yes, 4.7 should be open for backports after this week so please do it next week. Reopening for the backport. New Gerrit change created: https://git.eclipse.org/r/103140 Gerrit change https://git.eclipse.org/r/103140 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=6e860a177bc54cece2852bc3f276f591aee93114 New Gerrit change created: https://git.eclipse.org/r/103141 Gerrit change https://git.eclipse.org/r/103141 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=809381b1d63a0b49c4ddac27b3ab6757748e3ae5 New Gerrit change created: https://git.eclipse.org/r/103144 Gerrit change https://git.eclipse.org/r/103144 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=244663ffaaa14421791e7f35df02b6e996874386 Backported. |
Created attachment 268630 [details] Please find in attachment the plugin and its source to reproduce the problem When a topic references a href with anchor, using "Print selected topics and all subtopics" produces in Table of content a broken link. Please find in attachment an image to illustrate the problem and a plugin to test. The plugin consists of a toc with some chapters and topics. Links to chapters work since their href refers to a html while links to topics fail since their href refers to an anchor in a html