Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 517171

Summary:	Include icon source files in git repository
Product:	[Technology] EGit	Reporter:	Thomas Wolf <twolf>
Component:	UI	Assignee:	Thomas Wolf <twolf>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	matthias.sohn
Version:	unspecified
Target Milestone:	4.9.0
Hardware:	PC
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=517169 https://git.eclipse.org/r/98597 https://git.eclipse.org/c/egit/egit.git/commit/?id=8e7f487d2035b39c112bebd0e1668f02a1e2a01f
Whiteboard:

Description Thomas Wolf

2017-05-24 05:51:48 EDT

EGit should have the source files for all its icons in the git repository.

In general, icons should be based on SVG sources, like those from eclipse.platform.images. SVG makes composing new icons from existing ones simpler than any bitmap format.

I suggest a new top-level folder ./icons in the repo containing these source files. 

See also bug 517169.

Note: the SVGs will not be included in the bundles. To create a new icon, a new SVG will have to added, and the designer needs to export two PNGs (normal and @2x resolution) and copy them manually into the right EGit bundle at the right place. As a long-term vision (and not part of this issue), we could even think about generating the PNGs automatically during the Hudson build and copying them automatically to the right places before building the bundles.

Comment 1 Matthias Sohn

2017-05-24 07:19:49 EDT

(In reply to Thomas Wolf from comment #0)
> EGit should have the source files for all its icons in the git repository.
> 
> In general, icons should be based on SVG sources, like those from
> eclipse.platform.images. SVG makes composing new icons from existing ones
> simpler than any bitmap format.
> 
> I suggest a new top-level folder ./icons in the repo containing these source
> files. 

+1

> See also bug 517169.
> 
> Note: the SVGs will not be included in the bundles. To create a new icon, a
> new SVG will have to added, and the designer needs to export two PNGs
> (normal and @2x resolution) and copy them manually into the right EGit
> bundle at the right place. As a long-term vision (and not part of this
> issue), we could even think about generating the PNGs automatically during
> the Hudson build and copying them automatically to the right places before
> building the bundles.

yes, this would be nice

Comment 2 Eclipse Genie

2017-06-04 09:27:54 EDT

New Gerrit change created: https://git.eclipse.org/r/98597

Comment 3 Eclipse Genie

2017-06-13 15:24:05 EDT

Gerrit change https://git.eclipse.org/r/98597 was merged to [master].
Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=8e7f487d2035b39c112bebd0e1668f02a1e2a01f