Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 517075

Summary:	BendConnectionPolicy should use operations that uses IBendableContentPart
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	matthias.wienand
Version:	1.0.0
Target Milestone:	5.0.0 (Oxygen) RC2
Hardware:	All
OS:	All
Whiteboard:

Description Alexander Nyßen

2017-05-22 09:28:50 EDT

Similar to ResizePolicy and TransformPolicy, BendConnectionPolicy should use operations (for visual and content bending) that use the setVisualBendPoints() and setContentBendPoints() of IBendableContentPart. Up to now, the policy works around the IBendableContentPart interface.

Comment 1 Matthias Wienand

2017-05-22 09:33:50 EDT

For content bend points, the policy already uses BendContentOperation that delegates to IBendableContentPart#setContentBendPoints(). On the other hand, the BendConnectionOperation currently replaces the anchors for the manipulated Connection, instead of delegating to IBendableContentPart#setVisualBendPoints().

Comment 2 Matthias Wienand

2017-05-29 09:28:42 EDT

I removed BendConnectionOperation and added BendVisualOperation as a replacement that exchanges the (visual) bend points of an IBendableContentPart, instead of exchanging the anchors of the corresponding Connection visual. Moreover, I removed UpdateAnchorHintsOperation. The hints are now set as positions for attached bend points.

The code is published on the master branch, therefore, I resolve this ticket as fixed for 5.0.0 RC2.