Bugzilla – Full Text Bug Listing
| Summary: | The toString of class BundleModel always returns 'Unknown Bundle Model' | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Olivier Prouvost <olivier.prouvost> |
| Component: | UI | Assignee: | Andrey Loskutov <loskutov> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | trivial | ||
| Priority: | P3 | CC: | Lars.Vogel, loskutov, Vikas.Chandra |
| Version: | 4.5 | Flags: | Lars.Vogel:
review+
Vikas.Chandra: review+ |
| Target Milestone: | 4.7 RC1 | ||
| Hardware: | PC | ||
| OS: | All | ||
| See Also: |
https://git.eclipse.org/r/97303 https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=439ecbb31ae6631cbc298552c2ab5f19b2a1466e |
||
| Whiteboard: | |||
New Gerrit change created: https://git.eclipse.org/r/97303 Good catch! I will triage this to 4.8M1 when that target milestone is available. IMHO this qualifies as polish. Thanks Lars, I deliberated and was 50-50. Sooner is always better :) (In reply to Vikas Chandra from comment #5) > Thanks Lars, I deliberated and was 50-50. > > Sooner is always better :) Thanks, I read this as "ok to merge for RC1". I merge soon if I do hear otherwise. Gerrit change https://git.eclipse.org/r/97303 was merged to [master]. Commit: http://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=439ecbb31ae6631cbc298552c2ab5f19b2a1466e Thanks Lars ! Verified in I20170528-2000 |
In the class : org.eclipse.pde.internal.core.bundle.BundleModel toString method is : public String toString() { if (fBundle != null) { StringBuffer buf = new StringBuffer(); buf.append(fBundle.getHeader(Constants.BUNDLE_SYMBOLICNAME)); buf.append(" ("); //$NON-NLS-1$ buf.append(fBundle.getHeader(Constants.BUNDLE_VERSION)); buf.append(')'); } return "Unknown bundle model"; //$NON-NLS-1$ } It always returns Unknown bundle model and this method is not overridden in the unique child (org.eclipse.pde.internal.core.bundle.WorkspaceBundleModel).