Bugzilla – Full Text Bug Listing
| Summary: | [pmi] Assume that Project Leads listed on the proposal are committers | ||
|---|---|---|---|
| Product: | Community | Reporter: | Wayne Beaton <wayne.beaton> |
| Component: | Project Management & Portal | Assignee: | Eric Poirier <eric.poirier> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | chris.guindon, julien.ponge, wayne.beaton, webmaster |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | stalebug | ||
|
Description
Wayne Beaton
*** Bug 470674 has been marked as a duplicate of this bug. *** This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. Hi Wayne, Do we still need to address this issue with the current version of the PMI? Thanks. (In reply to Eric Poirier from comment #3) > Do we still need to address this issue with the current version of the PMI? Yes (In reply to Wayne Beaton from comment #0) > > Perhaps we can include a warning when the project lead is not also listed as > a committer and to give EMO a chance to sort it out. What if we throw an error if a project lead is not also listed as a committer? We could then let the project proposal creator know that there might be an error in the list of committers/project leads since we can't find a match in the both lists. This way when the proposal reaches EMO, there are less chances of errors. Let me know what you think. Thanks. I like this idea. We already display a bunch of warnings at the top of the page. Maybe we just need to add a similar message there. A "project leads must be listed as committers" message could be added to the Project_Proposal#getMissingMinimalRequiredValues method. (In reply to Wayne Beaton from comment #6) > I like this idea. > > We already display a bunch of warnings at the top of the page. Maybe we just > need to add a similar message there. > > A "project leads must be listed as committers" message could be added to the > Project_Proposal#getMissingMinimalRequiredValues method. Sounds good. Along with the error message, I will also add a line at the top of the page mentioning that Project leads also needs to be listed in the Committer section. (In reply to Eric Poirier from comment #7) > Along with the error message, I will also add a line at the top of the page > mentioning that Project leads also needs to be listed in the Committer > section. Sure. FYI, if you add an entry to #getMissingMinimalRequiredValues, the implementation will actively stop the user (EMO) from being able to end the proposal phase, create the project, and initiate provisioning (i.e., they will be motivated to resolve the issue). Note that a misalignment is considered a valid invalid state. That is, while the proposal is being created, it's acceptable to save the current (invalid) state and then come back to edit it more later. (In reply to Wayne Beaton from comment #8) > (In reply to Eric Poirier from comment #7) > > Along with the error message, I will also add a line at the top of the page > > mentioning that Project leads also needs to be listed in the Committer > > section. > > Sure. > > FYI, if you add an entry to #getMissingMinimalRequiredValues, the > implementation will actively stop the user (EMO) from being able to end the > proposal phase, create the project, and initiate provisioning (i.e., they > will be motivated to resolve the issue). > > Note that a misalignment is considered a valid invalid state. That is, while > the proposal is being created, it's acceptable to save the current (invalid) > state and then come back to edit it more later. Ah ok I see what you mean. So instead of throwing an error message on Submit, we would simply prevent the proposal from moving forward if a PL is not also a CM in the list. > Ah ok I see what you mean. So instead of throwing an error message on
> Submit, we would simply prevent the proposal from moving forward if a PL is
> not also a CM in the list.
+1
Hi Wayne, The patch that I created is now on production. When a user is entered in the project lead section and is not in the committer section, the node saves but we see a message at the top of the page preventing the proposal to go any further. I used getMissingMinimalRequiredValues as you suggested. Please reopen this bug if there's an issue with this update. Thanks! |