Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 516228

Summary: Preference dialog of synchronize view shows missing image icon
Product: [Eclipse Project] Platform Reporter: Rüdiger Herrmann <ruediger.herrmann>
Component: TeamAssignee: Rüdiger Herrmann <ruediger.herrmann>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: daniel_megert, loskutov, ruediger.herrmann
Version: 4.7   
Target Milestone: 4.7 M7   
Hardware: PC   
OS: All   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=425987
https://git.eclipse.org/r/96459
https://git.eclipse.org/c/platform/eclipse.platform.team.git/commit/?id=9082ea813cd5e1ccc044cd341da2540a8ed3103e
Whiteboard:
Attachments:
Description Flags
Screenshot of preference dialog none

Description Rüdiger Herrmann CLA 2017-05-05 05:22:28 EDT
Created attachment 268179 [details]
Screenshot of preference dialog

The preference dialog that can be opened from the synchronize view's drop-down menu shows a red square banner image (see screenshot).

The reason, therefore, is, that the PreferencePageContainerDialog tries to load .gif images from a JFace package whereas there are only .png files available.
Comment 1 Andrey Loskutov CLA 2017-05-05 05:29:05 EDT
Regression from bug 425987 commit 99bff60a04292f1a378eaf784be78b51b98c5bd2

org.eclipse.jface.resource.DeviceResourceException: Unable to create resource FileImageDescriptor(location=class org.eclipse.jface.preference.PreferenceDialog, name=images/pref_dialog_title.gif)
	at org.eclipse.jface.resource.ImageDescriptor.createResource(ImageDescriptor.java:182)
	at org.eclipse.jface.resource.DeviceResourceManager.allocate(DeviceResourceManager.java:52)
	at org.eclipse.jface.resource.AbstractResourceManager.create(AbstractResourceManager.java:85)
	at org.eclipse.jface.resource.ResourceManager.createImageWithDefault(ResourceManager.java:192)
	at org.eclipse.jface.resource.ImageRegistry.get(ImageRegistry.java:203)
	at org.eclipse.team.internal.ui.dialogs.PreferencePageContainerDialog.createMessageArea(PreferencePageContainerDialog.java:276)
	at org.eclipse.team.internal.ui.dialogs.PreferencePageContainerDialog.createDescriptionArea(PreferencePageContainerDialog.java:209)
	at org.eclipse.team.internal.ui.dialogs.PreferencePageContainerDialog.createDialogArea(PreferencePageContainerDialog.java:115)
Comment 2 Eclipse Genie CLA 2017-05-05 05:58:39 EDT
New Gerrit change created: https://git.eclipse.org/r/96459
Comment 4 Dani Megert CLA 2017-05-05 06:12:45 EDT
Thanks for the fix!