Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 516075

Summary: The current binding for IHandlerResolver within MvcFxModule is not correct.
Product: [Tools] GEF Reporter: Alexander Nyßen <nyssen>
Component: GEF MVCAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: major    
Priority: P3    
Version: 1.0.0   
Target Milestone: 5.0.0 (Oxygen) M7   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 516080    
Bug Blocks:    

Description Alexander Nyßen CLA 2017-05-02 23:52:21 EDT 
The current binding for IHandlerResolver -> DefaultHandlerResolver is not correct. The method names still refer to ITargetPolicyResolver.

Further, the binding does not happen in two steps (bind interface as adapter, bind default implementation to interface), but the default implementation is directly bound as adapter (while the interface is still bound). When changing this to two-step bindings, it seems the scoping does not longer work (which might point to a problem in AdaptableScopes).

We need to check whether scoping to domain is actually intended here. If so, we need to investigate why the scoping leads to an exception. In either case, the binding should be done in two steps, so clients can easily exchange the IHandlerResolver, which is a common use case.
Comment 1 Alexander Nyßen CLA 2017-05-03 02:59:23 EDT 
Ensured binding for IHandlerResolver is done in two steps.
- First binding IHandlerResolver as domain adapter (scoped to domain).
- Bind IDefaultHandlerResolver to IHandlerResolver.
    
This way, the default resolver should be easily replaceable.

Resolving as fixed in 5.0.0 M7.