Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 516057

Summary:	Exception in orion.eclipse.org (TypeError: callback is not a function)
Product:	[ECD] Orion	Reporter:	Silenio Quarti <Silenio_Quarti>
Component:	Node	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	15.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Silenio Quarti

2017-05-02 11:55:29 EDT

After the changes for bug#515770, this exception started happening occasionally in orion.eclipse.org.

{"stack":"TypeError: callback is not a function\n    at /home/admin/orionode/orionode/lib/metastore/mongodb/store.js:285:12\n    at /home/admin/orionode/orionode/node_modules/mongoose/lib/query.js:2749:9\n    at tryCatcher (/home/admin/orionode/orionode/node_modules/bluebird/js/release/util.js:16:23)\n    at Promise._settlePromiseFromHandler (/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js:512:31)\n    at Promise._settlePromise (/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js:569:18)\n    at Promise._settlePromise0 (/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js:614:10)\n    at Promise._settlePromises (/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js:689:18)\n    at Async._drainQueue (/home/admin/orionode/orionode/node_modules/bluebird/js/release/async.js:133:16)\n    at Async._drainQueues (/home/admin/orionode/orionode/node_modules/bluebird/js/release/async.js:143:10)\n    at Immediate.Async.drainQueues [as _onImmediate] (/home/admin/orionode/orionode/node_modules/bluebird/js/release/async.js:17:14)\n    at processImmediate [as _immediateCallback] (timers.js:383:17)","stackframes":[{"line_number":285,"file_name":"/home/admin/orionode/orionode/lib/metastore/mongodb/store.js"},{"line_number":2749,"file_name":"/home/admin/orionode/orionode/node_modules/mongoose/lib/query.js"},{"line_number":16,"file_name":"/home/admin/orionode/orionode/node_modules/bluebird/js/release/util.js"},{"line_number":512,"file_name":"/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js"},{"line_number":569,"file_name":"/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js"},{"line_number":614,"file_name":"/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js"},{"line_number":689,"file_name":"/home/admin/orionode/orionode/node_modules/bluebird/js/release/promise.js"},{"line_number":133,"file_name":"/home/admin/orionode/orionode/nod…

Comment 1 Silenio Quarti

2017-05-02 11:56:58 EDT

I checked all callers of store.js#updateUser and I cannot see any passing a bad callback parameter.

Comment 2 Silenio Quarti

2017-05-02 12:19:31 EDT

Took a closer look. Fixed

https://github.com/eclipse/orion.client/commit/2ccd345bf6ae62567f2423d53544df8fd9b812c3