Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 515929

Summary:	Version comparison in Ant does not support two numbers in minor position
Product:	[Eclipse Project] Platform	Reporter:	Sarika Sinha <sarika.sinha>
Component:	Ant	Assignee:	Sarika Sinha <sarika.sinha>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, markus.kell.r, nobody
Version:	4.7
Target Milestone:	4.7 M7
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/96304 https://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=b15e9500afb3f5b2788ff0f58f6d7034d40f9751
Whiteboard:
Bug Depends on:
Bug Blocks:	499717

Description Sarika Sinha

2017-04-27 23:43:30 EDT

While working on Bug 499717, found that the version comparison does not support more than 1 number in minur places like 1.10.1

Comment 1 Sarika Sinha

2017-04-27 23:44:07 EDT

(In reply to Sarika Sinha from comment #0)

> support more than 1 number in minur places like 1.10.1

minor

Comment 2 Sarika Sinha

2017-04-27 23:47:01 EDT

Fixed via
http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=08aa1ad308e9c8f763e29445b30cdc88093c3159

Comment 3 Eclipse Genie

2017-05-03 12:28:32 EDT

Gerrit change https://git.eclipse.org/r/96304 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=b15e9500afb3f5b2788ff0f58f6d7034d40f9751

Comment 4 Nobody - feel free to take it

2017-05-04 08:33:06 EDT

Please adapt patch also to R4_6_maintenance branch.

Comment 5 Dani Megert

2017-05-04 09:58:34 EDT

(In reply to Alien Huker from comment #4)
> Please adapt patch also to R4_6_maintenance branch.

Do you plan to build Eclipse yourself or you want to work off the repository? I asked because there won't be any 4.6.x builds anymore.

Comment 6 Nobody - feel free to take it

2017-05-04 10:38:42 EDT

I thought that there would still be a small release with bug fixes.
Because branch 4.7 has not yet become the release status(or RC).
But if there are no will builds anymore for 4.6, then probably there is no sense.

Comment 7 Dani Megert

2017-05-04 11:08:32 EDT

(In reply to Alien Huker from comment #6)
> I thought that there would still be a small release with bug fixes.
> Because branch 4.7 has not yet become the release status(or RC).
> But if there are no will builds anymore for 4.6, then probably there is no
> sense.

No, there are no further builds.

Comment 8 Dani Megert

2017-05-04 11:11:01 EDT

(In reply to Alien Huker from comment #6)
> I thought that there would still be a small release with bug fixes.
> Because branch 4.7 has not yet become the release status(or RC).

FYI: We will ship 4.7 M7 end of next week. This will also contain Ant 1.10.1. After M7 we go into the RC phase.

Comment 9 Markus Keller

2017-05-09 17:59:01 EDT

http://git.eclipse.org/c/platform/eclipse.platform.git/commit/?id=7606f039d955312f32fd8afbd4aee9ab4de2a7d7
Made the copied Version class static, and added Javadocs to explain provenance.