Bugzilla – Full Text Bug Listing
| Summary: | [CSS] [Dark Theme] Allow to set the TitleBarForeground of ExpandableComposite via CSS | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||
| Component: | UI | Assignee: | Fabian Pfaff <fabian.pfaff> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Lars.Vogel | ||||
| Version: | 4.7 | ||||||
| Target Milestone: | 4.7 M7 | ||||||
| Hardware: | PC | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/95322 https://git.eclipse.org/r/95387 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9a8613c1e1108657a0c4c52a4c2a023ce6fa2abb https://git.eclipse.org/r/96156 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f17d97d57e9f04bbd991e91f22da68190440cbaf https://bugs.eclipse.org/bugs/show_bug.cgi?id=521488 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 515518, 515520 | ||||||
| Attachments: |
|
||||||
David, lets look at this tomorrow. You know the code and I am the CSS styling, maybe we can have a fast fix for this. Looks to me that the CSS engine does not set the foregroundColor and background Color for Composite. I write a test to confirm that. (In reply to Lars Vogel from comment #2) > Looks to me that the CSS engine does not set the foregroundColor and > background Color for Composite. I write a test to confirm that. Nope, Composite works but not ExpandableComposite. I investigate further. The relevant method is setTitleBarForeground. ExpandableComposite needs a custom CSS handler for this. New Gerrit change created: https://git.eclipse.org/r/95322 Fabian, you already defined the new CSS handlers for tables and trees. Can you implement one for the ExpandableComposite calling its setTitleBarForeground method? For testing you can use the new test case from the Gerrit. CSS should be defined in the org.eclipse.ui.forms plug-in. New Gerrit change created: https://git.eclipse.org/r/95387 Gerrit change https://git.eclipse.org/r/95322 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9a8613c1e1108657a0c4c52a4c2a023ce6fa2abb Thanks Fabian This is not complete. setTitleBackground is ignored at the moment. We need to unconditionally save the color and also allow to set the hyperlink color. New Gerrit change created: https://git.eclipse.org/r/96156 Gerrit change https://git.eclipse.org/r/96156 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f17d97d57e9f04bbd991e91f22da68190440cbaf Fixed, will verify tomorrow. |
Created attachment 267839 [details] Screenshot