Bugzilla – Full Text Bug Listing
| Summary: | Error on saving when "Format code on save" enabled | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Robert Spies <wilford> |
| Component: | Client | Assignee: | Michael Rennie <Michael_Rennie> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P2 | CC: | eclipse, Michael_Rennie, Olivier_Thomann, remy.suen |
| Version: | 14.0 | Keywords: | triaged |
| Target Milestone: | 17.0 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| See Also: | https://github.com/eclipse/orion.client/pull/223 | ||
| Whiteboard: | |||
I'm not sure how this ever worked because mFormatter was never declared anywhere in the source file. https://github.com/eclipse/orion.client/blob/89320547caffc2258d314e91c70ad1445fbb6b32/bundles/org.eclipse.orion.client.ui/web/orion/inputManager.js#L479 The code was added to fix bug 423072. https://github.com/eclipse/orion.client/commit/eeff96ed057aca79de42521583f6aac6fcb42ba4 Same here. Cool feature idea, but if this is not going to be fixed maybe remove the setting? GitHub Pull Request 223 created by [mrennie] https://github.com/eclipse/orion.client/pull/223 Merged. |
Steps to repo: 1. Enabled "Format code on save" under editor settings. 2. Attempt to make a change and then save the file. Note that the save fails, and the exception occurs in the chrome console: ReferenceError: mFormatter is not defined at InputManager.save (https://8081-dot-1951683-dot-devshell.appspot.com/orion/inputManager.js:479:16) at InputManager.<anonymous> (https://8081-dot-1951683-dot-devshell.appspot.com/orion/inputManager.js:503:12) at https://8081-dot-1951683-dot-devshell.appspot.com/orion/EventTarget.js:42:8 at Array.forEach (native) at EventTarget.dispatchEvent (https://8081-dot-1951683-dot-devshell.appspot.com/orion/EventTarget.js:39:15) at Idle.onIdle (https://8081-dot-1951683-dot-devshell.appspot.com/orion/inputManager.js:56:16) at Idle.<anonymous> (https://8081-dot-1951683-dot-devshell.appspot.com/orion/inputManager.js:49:11)