Bugzilla – Full Text Bug Listing
|
Description
Andrey Loskutov
Created attachment 267774 [details]
image: area to insert the filter
Andrey, the empty area is to insert a text to filter the entries.
I could add a text "type to filter", to make it clear.
(In reply to Patrik Suzzi from comment #1) > Created attachment 267774 [details] > image: area to insert the filter > > Andrey, the empty area is to insert a text to filter the entries. > I could add a text "type to filter", to make it clear. Patrik, with "could" do you mean bug 515052 and bug 515060? Currently (in my build I20170409-2000) this area can't be used. I have no problems if you plan to add some filtering later, but please don't show this non functional area *now*. From my experience, most of "I will do it later" tasks will never be implemented (we all have only 24 hours in the day), so better not to add things at all which rely on future promises. AFAIK Ctrl+F6 wasn't broken. I've reverted the other two no go changes already. (In reply to Dani Megert from comment #3) > AFAIK Ctrl+F6 wasn't broken. I've reverted the other two no go changes > already. Nope. I'm running now I20170412-2000 (with reverted code) and still see non-functional white area without title. (In reply to Dani Megert from comment #3) > AFAIK Ctrl+F6 wasn't broken. Just confirmed that this one *also* has an empty white area without any function or title :-( (In reply to Andrey Loskutov from comment #4) > (In reply to Dani Megert from comment #3) > > AFAIK Ctrl+F6 wasn't broken. I've reverted the other two no go changes > > already. > > Nope. I'm running now I20170412-2000 (with reverted code) and still see > non-functional white area without title. It works for me: 1. Download http://download.eclipse.org/eclipse/downloads/drops4/I20170412-2000/download.php?dropFile=eclipse-SDK-I20170412-2000-win32-x86_64.zip 2. Start a new workspace 3. Paste "class A {}" into the Package Explorer 4 Use Ctrl+F6/F7/F8 ==> works for me, i.e. no filter but a title for all three cases. Maybe your update wrong? Please try my steps. (In reply to Dani Megert from comment #6) > (In reply to Andrey Loskutov from comment #4) > > (In reply to Dani Megert from comment #3) > > > AFAIK Ctrl+F6 wasn't broken. I've reverted the other two no go changes > > > already. > > > > Nope. I'm running now I20170412-2000 (with reverted code) and still see > > non-functional white area without title. > > It works for me: > > 1. Download > http://download.eclipse.org/eclipse/downloads/drops4/I20170412-2000/download. > php?dropFile=eclipse-SDK-I20170412-2000-win32-x86_64.zip > > 2. Start a new workspace > > 3. Paste "class A {}" into the Package Explorer > > 4 Use Ctrl+F6/F7/F8 > > ==> works for me, i.e. no filter but a title for all three cases. > > > Maybe your update wrong? Please try my steps. I'm on RHEL 7.2 and did exact same steps except that I'm using GTK3 build. I see empty white area in all 3 dialogs, no title and also no filtering. Created attachment 267786 [details]
still empty area on I20170412-2000
Created attachment 267787 [details]
not empty in dark theme
OK, I've found where the problem is: the title is shown in *white* color on white background! The dark theme has no such issues, but "Light" and "Classic" themes seem to be broken on GTK (or the code of the dialog is using wrong foreground font color constant).
New Gerrit change created: https://git.eclipse.org/r/94970 (In reply to Andrey Loskutov from comment #9) > Created attachment 267787 [details] > not empty in dark theme > > OK, I've found where the problem is: the title is shown in *white* color on > white background! The dark theme has no such issues, but "Light" and > "Classic" themes seem to be broken on GTK (or the code of the dialog is > using wrong foreground font color constant). Is this something new then, or did you only notice now? If the former, what bug introduced this? (In reply to Dani Megert from comment #11) > (In reply to Andrey Loskutov from comment #9) > > Created attachment 267787 [details] > > not empty in dark theme > > > > OK, I've found where the problem is: the title is shown in *white* color on > > white background! The dark theme has no such issues, but "Light" and > > "Classic" themes seem to be broken on GTK (or the code of the dialog is > > using wrong foreground font color constant). > > Is this something new then, or did you only notice now? If the former, what > bug introduced this? I've just noticed this because there was this disccussion about filter line etc and I wondered that I neither have the filter nor the title :-) Probably this was regression from bug 368977, where the code was introduced, but I didn't bisect this. Gerrit change https://git.eclipse.org/r/94970 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0fc86ce8ba5868aa1b01cd4e89edc79a50854e7b (In reply to Eclipse Genie from comment #13) > Gerrit change https://git.eclipse.org/r/94970 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=0fc86ce8ba5868aa1b01cd4e89edc79a50854e7b I've verified the fix works on Linux and Windows 7 in all themes, I assume this will also work on Mac (have no access to it). New Gerrit change created: https://git.eclipse.org/r/94982 Gerrit change https://git.eclipse.org/r/94982 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e3da830e77410671ff27ecfaf728c2717b64b18f (In reply to Andrey Loskutov from comment #14) > (In reply to Eclipse Genie from comment #13) > > Gerrit change https://git.eclipse.org/r/94970 was merged to [master]. > > Commit: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > > ?id=0fc86ce8ba5868aa1b01cd4e89edc79a50854e7b > > I've verified the fix works on Linux and Windows 7 in all themes, I assume > this will also work on Mac (have no access to it). This is not good. There's always the possibility of a clash when we mix foreground and background colors from different elements. The safest is to use protected Color getForeground(){ return dialog.getDisplay().getSystemColor(SWT.COLOR_LIST_FOREGROUND); } protected Color getBackground() { return dialog.getDisplay().getSystemColor(SWT.COLOR_LIST_BACKGROUND); } because those already work at the OS level. Alternatively, it could be the foreground and background color of a theme element, but no mix. Andrey, please check whether that works for you. New Gerrit change created: https://git.eclipse.org/r/94991 (In reply to Dani Megert from comment #17) > (In reply to Andrey Loskutov from comment #14) > > (In reply to Eclipse Genie from comment #13) > > > Gerrit change https://git.eclipse.org/r/94970 was merged to [master]. > > > Commit: > > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > > > ?id=0fc86ce8ba5868aa1b01cd4e89edc79a50854e7b > > > > I've verified the fix works on Linux and Windows 7 in all themes, I assume > > this will also work on Mac (have no access to it). > > This is not good. There's always the possibility of a clash when we mix > foreground and background colors from different elements. I see, thanks. > dialog.getDisplay().getSystemColor(SWT.COLOR_LIST_FOREGROUND); > Andrey, please check whether that works for you. Yes, this is OK on GTK3 / Win 7. Gerrit change https://git.eclipse.org/r/94991 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=2b1ce323d22a7852f6ef7912944e153baba6adb1 |