Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 514433

Summary:	[CSS][lint] Remove 'Too many' problems
Product:	[ECD] Orion	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	JS Tools	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	steve_northover
Version:	13.0
Target Milestone:	15.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Curtis Windatt

2017-03-29 13:35:18 EDT

CSS Lint has an 'important' rule that marks use of !important directives. The problem is that the rule implementation also checks if there are more than 10 of the directives in the file, and if so, adds a warning to the start of the file.

With Bug 512330 we can ignore the annotations, but the "Too many" problem will stay and there is no way to turn it off.

We should disable that portion of the rule entirely as it provides no value.  I will also check if there are other rules with a similar pattern.

Comment 1 Steve Northover

2017-03-29 15:09:20 EDT

That would be great (turning off unhelpful warning at the top).  In another bug somewhere, we were enumerating the other cases of this problem.

Comment 2 Curtis Windatt

2017-03-29 15:59:47 EDT

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a01f5a7c737f00365405d73afb97a1711e74946b
Fixed in master and updated tests

For important and ids rules I disable the 'too many' portion of the rule.

For the 5 rules that always use counts, I prevent the ignore quickfix from showing up because it doesn't work (ignore disables a problem on a given line, but these rules run on the entire file).