Bugzilla – Full Text Bug Listing
| Summary: | Tooling colors are not part of the editor theme (hence can be unsee-able) | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Steve Northover <snorthov> | ||||
| Component: | Client | Assignee: | XinYi Jiang <xinyij> | ||||
| Status: | CLOSED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P2 | CC: | Carolyn_MacLeod, Silenio_Quarti | ||||
| Version: | unspecified | ||||||
| Target Milestone: | 15.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Windows 7 | ||||||
| See Also: | https://github.com/eclipse/orion.client/pull/21 | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
*** Bug 514403 has been marked as a duplicate of this bug. *** From the dup: There are still some colors that show up in the editor that cannot be themed. Here's an initial list: - the error/warning/info wavy underline colors - the bracket-matching highlight color - the color of "occurrences" - annotations such as /** @private */ in a js file All of these colors need to be added to the Editor theming. This is mainly because there are 2 main IDE themes - one light and one dark - so the editor colors need to show up on a light background or a dark background, which is not possible unless they can be changed. *** Bug 513265 has been marked as a duplicate of this bug. *** From the dup: The squiggles color for info and warning annotations are hard to see in the Dark theme. We need support to allow different themes have different colors for squiggles. See bug#513192 for code to create squiggles images from a color. GitHub Pull Request 21 created by [soulbeing] https://github.com/eclipse/orion.client/pull/21 |
Created attachment 267529 [details] yellow on a dark background If you switch to a dark editor theme, the yellow warning color ("ocre") for JS tooling is harder to see that "plain yellow". This is just one instance of the problem. The editor theme must include all colors that the editor uses or we will have unsee-ables.