Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 514269

Summary:	[pmi] Exclude "nopiggyback" CQs when doing a query for piggybacks.
Product:	Community	Reporter:	Wayne Beaton <wayne.beaton>
Component:	Project Management & Portal	Assignee:	Eclipse Management Organization <emo>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	P1	CC:	eric.poirier, sharon.corbett, wayne.beaton, webmaster
Version:	unspecified
Target Milestone:	---
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:	510058
Bug Blocks:

Description Wayne Beaton

2017-03-27 12:31:03 EDT

When presenting the user with a list of potential CQs to piggyback, exclude those CQs marked with the "nopiggybacks" keyword.

Comment 1 Eric Poirier

2017-05-19 13:55:02 EDT

Hi Wayne,

I think here you mean if the user clicked on the Third-Party Code Request the user is presented with a list.

I don't see the keyword "nopiggybacks" but I do see "thirdparty". Would I then be looking for all the rows that have the keyword "thirdparty"?

That looks like it, but I just want to make sure I got this right.

Thanks!

Comment 2 Wayne Beaton

2017-05-31 16:40:14 EDT

"nopiggybacks" is a new keyword. I'm not surprised that we don't have it applied to any CQs yet.

Ideally, that list should include everything that has the "thirdparty" keyword but does not have the "nopiggybacks" keyword.

We should also exclude piggybacks themselves, I believe (Sharon will argue if I'm wrong). Piggyback are identified in the summary line "(PB ...)" and similar. In fact, we can probably also ignore the ATO

CQs with summaries that match following regular expressions can be skipped:

'/ATO\s+Orbit\s+(\d+)/'
'/ATO\s*CQ\s*([0-9]+)/'
'/PB\s*CQ\s*([0-9]+)/'
'/PB\s*([0-9]+)/'
'/Orbit\s*(?:CQ)?\s*([0-9]+)/'

We can probably be more clever and combine some of these, but I decided to go with marginally readable.

Comment 3 Sharon Corbett

2018-07-24 09:36:28 EDT

Eric:  Its a keyword you are looking for that contains "nopiggybacks".  There are currently 17 CQs in the system containing this keyword.

We (Wayne and I) would like to raise the priority of this issue as it is critical others do not automatically piggyback on these CQs now that the system processes piggybacks automatically.

In fact ensuring this does not happen is crucial.

Thanks,
Sharon

Comment 4 Eric Poirier

2018-07-24 15:33:25 EDT

Hi Wayne,

The CQs marked with the "nopiggybacks" keyword are now ignored when creating a thirdparty CQ on the production website.

Now closing this bug, please reopen if there's an issue with this change.

Thanks!