Bug 514034

Comment 1 Lars Vogel 2017-03-21 23:46:00 EDT

Preference: 

/instance/org.eclipse.ui.editors show_range_indicator true

Comment 2 Eclipse Genie 2017-03-22 00:17:52 EDT

New Gerrit change created: https://git.eclipse.org/r/93590

Comment 3 Eclipse Genie 2017-03-22 00:18:35 EDT

Gerrit change https://git.eclipse.org/r/93590 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b113731f0f6b10915cc40838e7fe99442949f69e

Comment 4 Lars Vogel 2017-03-22 00:19:28 EDT

Gorkem / Fred, in case you want to try it out, please use the I-Build as of tomorrow: http://download.eclipse.org/eclipse/downloads/

Comment 5 Andrey Loskutov 2017-03-22 01:39:47 EDT

I would never associate themes with functional changes, this confuses users, remember MRU story. Themes schould only chane L&F. 

So to properly fix this, range indicator should use theme colors. So I'm -2 for the commit.

Comment 6 Lars Vogel 2017-03-22 02:22:50 EDT

(In reply to Andrey Loskutov from comment #5)
> I would never associate themes with functional changes, this confuses users,
> remember MRU story. Themes schould only chane L&F. 

This change did disactivate the broken L&F of the dark theme. Hightlight Color can not be customized at the moment. Please open a new bug for this request.

Comment 7 Markus Keller 2017-03-22 06:52:07 EDT

(In reply to Lars Vogel from comment #6)
> (In reply to Andrey Loskutov from comment #5)
> > I would never associate themes with functional changes, this confuses users,
> > remember MRU story. Themes schould only chane L&F. 
> 
> This change did disactivate the broken L&F of the dark theme. Hightlight
> Color can not be customized at the moment. Please open a new bug for this
> request.

No Lars, that's not how it works. You committed a functional change that breaks expected behavior, so it's your job to do what you can to fix the breakage.

Comment 8 Eclipse Genie 2017-03-22 07:00:37 EDT

New Gerrit change created: https://git.eclipse.org/r/93604

Comment 9 Eclipse Genie 2017-03-22 07:01:00 EDT

Gerrit change https://git.eclipse.org/r/93604 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=dd2c244b71479d86719da8364f24b393b5c4f3c4

Comment 10 Lars Vogel 2017-03-22 07:03:40 EDT

I'm unsure what I broke with the change, except fixing a super ugly UI issue in the dark theme but as Andrey and Markus disagree, I reverted the fix. 

Lets use Bug 514043 to make the color configurable so that dark theme users can suffer less. 

Workaround for existing dark theme users is to disable the preference manually.

Comment 11 Andrey Loskutov 2017-03-22 10:12:14 EDT

(In reply to Lars Vogel from comment #10)
> I'm unsure what I broke with the change, except fixing a super ugly UI issue
> in the dark theme

Lars, the fix was done at wrong place. As said before, we should not enable or disable some functionality via themes, but make sure that this functionality supports different themes.

With your fix users in the dark theme would miss the range indicator feature and file a bug that it doesn't work anymore. No one expects to see a functional change only by changing L&F.

Comment 12 Lars Vogel 2017-03-22 10:32:41 EDT

Thanks Andrey, for the clarification. I can see your point.