Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 513500

Summary: [tool] adding a new Log port creates error message
Product: [Modeling] Papyrus-rt Reporter: Ernesto Posse <eposse>
Component: toolAssignee: Project Inbox <papyrusrt-inbox>
Status: CLOSED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: peter.cigehn
Version: 0.9.0   
Target Milestone: ---   
Hardware: PC   
OS: Mac OS X   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=492356
https://bugs.eclipse.org/bugs/show_bug.cgi?id=513060
Whiteboard:

Description Ernesto Posse CLA 2017-03-10 17:12:00 EST
I don't know if this is mac-specific or not, but just adding a new log port results in an error message: "A Port with an invalid text string found".

It looks like a validation error, but it occurs without explicitly doing right-click->Validation.

The port has a UML Comment which contains: "# log : UMLRT-RTS::Log::Log {ordered, unique}".

Removing the comment and doing validation removes the error message. Incidentally, trying to undo the comment-deletion doesn't work.

I assigned it version 0.9.0 since we already updated the version number in the git repo.

I'd recommend to set the target milestone to 0.9.0 as well, since we don't want users to get an error when creating ports.
Comment 1 Peter Cigehn CLA 2017-03-11 03:56:07 EST
This is a duplicate of Bug 513060 which in its turn is a duplicate of Bug 512809. The issue is related to the direct editor for ports, which cannot resolve the system protocol in the run-time model library. It should only happen if the port is created using the new child menu in the model explorer. It is a bit unclear from the description, but I assume that this is how the port was created. It should not happen if the port based on a system protocol is created using the port tool on the palette.
Comment 2 Ernesto Posse CLA 2017-03-13 10:51:50 EDT
(In reply to Peter Cigehn from comment #1)
> This is a duplicate of Bug 513060 which in its turn is a duplicate of Bug
> 512809. The issue is related to the direct editor for ports, which cannot
> resolve the system protocol in the run-time model library. It should only
> happen if the port is created using the new child menu in the model
> explorer. It is a bit unclear from the description, but I assume that this
> is how the port was created. It should not happen if the port based on a
> system protocol is created using the port tool on the palette.


Indeed I was creating the port with the model explorer.
Comment 3 Peter Cigehn CLA 2017-03-15 08:04:34 EDT
Since Bug 513060 has been resolved, this bug should also have been resolved. I suggest to either simple close it by marking it as a duplicate of Bug 513060, or close it if the fix provided by Bug 513060 is considered to have fixed this one as well.
Comment 4 Ernesto Posse CLA 2017-03-15 11:45:05 EDT
It looks fine to me as well, as the UML Comment under the port is no longer created. I assume that's the intention?

Anyway, I'll close it.
Comment 5 Ernesto Posse CLA 2017-03-15 11:45:16 EDT
Verified.
Comment 6 Ernesto Posse CLA 2017-03-15 11:45:26 EDT
Closed.
Comment 7 Peter Cigehn CLA 2017-03-15 11:49:17 EDT
(In reply to Ernesto Posse from comment #4)
> It looks fine to me as well, as the UML Comment under the port is no longer
> created. I assume that's the intention?
> 
> Anyway, I'll close it.

Yes, that is the intention. The direct editor is now a much simpler one, that only provides changing the name of the port, and not its type (and other properties) as before, which was what causes the comment element to be created (and the problem marker to appear) when the port was typed by a system protocol in the run-time model library. For some reason the director editor provided by base Papyrus could not resolve the system protocol, probably due to that it was not part of the current model, and hence the comment element and the problem marker appeared. This should now no longer happen.