Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 513492

Summary:	[webkit2] Port VisibilityWindow event details
Product:	[Eclipse Project] Platform	Reporter:	Leo Ufimtsev <lufimtse>
Component:	SWT	Assignee:	Leo Ufimtsev <lufimtse>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	akurtakov
Version:	4.7
Target Milestone:	4.7 M7
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/93153 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d68bb8bb075234615d04458d0be65d874f9a722a https://git.eclipse.org/r/93201 https://git.eclipse.org/r/93297 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a428d7cc84d7b3df4c54401f685ddd8bab358790
Whiteboard:
Bug Depends on:
Bug Blocks:	441568

Description Leo Ufimtsev

2017-03-10 15:29:55 EST

Via code inspection, I see that for the visibility Window event is populated via webkit1 only:

Window_features:
https://webkitgtk.org/reference/webkitgtk/unstable/WebKitWebWindowFeatures.html

For webkit2, we should be using Window Properties:
https://webkitgtk.org/reference/webkit2gtk/stable/WebKitWindowProperties.html

In the function webkit_web_view_ready, I need to implement a branching mechanism such that for webkit2, window properties are used.

Height/Width x/y information seems to be missing in properties. This might be by design. I'll have to investigate.

Comment 1 Eclipse Genie

2017-03-15 15:23:20 EDT

New Gerrit change created: https://git.eclipse.org/r/93153

Comment 2 Eclipse Genie

2017-03-16 04:21:33 EDT

Gerrit change https://git.eclipse.org/r/93153 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d68bb8bb075234615d04458d0be65d874f9a722a

Comment 3 Eclipse Genie

2017-03-16 09:44:51 EDT

New Gerrit change created: https://git.eclipse.org/r/93201

Comment 4 Eclipse Genie

2017-03-17 10:19:37 EDT

New Gerrit change created: https://git.eclipse.org/r/93297

Comment 5 Eclipse Genie

2017-03-17 10:30:52 EDT

Gerrit change https://git.eclipse.org/r/93297 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=a428d7cc84d7b3df4c54401f685ddd8bab358790

Comment 6 Leo Ufimtsev

2017-03-17 10:31:44 EDT

The original patch caused some build failures due to typo.

I've fixed the typo. Have to wait till tomorrow/Monday to check if build failures still occur.

Comment 7 Leo Ufimtsev

2017-03-21 16:51:45 EDT

(In reply to Leo Ufimtsev from comment #6)
> The original patch caused some build failures due to typo.
> 
> I've fixed the typo. Have to wait till tomorrow/Monday to check if build
> failures still occur.

No build failures. All is well.