Bugzilla – Full Text Bug Listing
| Summary: | server crash caused by import of .zip | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Grant Gayed <grant_gayed> | ||||
| Component: | Node | Assignee: | Grant Gayed <grant_gayed> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | critical | ||||||
| Priority: | P1 | CC: | kuschel, Silenio_Quarti, steve_northover | ||||
| Version: | unspecified | Flags: | Silenio_Quarti:
review+
|
||||
| Target Milestone: | 14.0 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
If we are confident that it is just this .zip then we can investigate at a later date. Currently the server will crash for any .zip it thinks is invalid. In this case it's a valid .zip that seems to be hitting a bug in the dependent library, but if I took any other zip and tinkered with its bits I could use it to bring down Orion similarly. I have a fix that is pretty straight-forward, will run it past SSQ later today. Seems like we need to catch the error and not exit? |
Created attachment 267173 [details] .zip file that causes the crash - drag the attached .zip file into a project - answer Ok to the 'Unzip marked-it-files.zip?' prompter - the server is crashed with: events.js:160 throw er; // Unhandled 'error' event ^ Error: invalid stored block lengths at Zlib._handle.onerror (zlib.js:370:17) I don't know what's special about this .zip that causes the crash, importing of other .zips in general doesn't cause this. I've confirmed that unzipping it at the command line works fine, so it appears to be valid.