Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 513254

Summary:	Add explicit visual decoration (grey lock) for read-only elements
Product:	[Modeling] Sirius	Reporter:	Pierre-Charles David <pierre-charles.david>
Component:	Properties	Assignee:	Project Inbox <sirius.properties-inbox>
Status:	CLOSED FIXED	QA Contact:	Laurent Fasani <laurent.fasani>
Severity:	enhancement
Priority:	P3	CC:	laurent.fasani, steve.monnier
Version:	4.1.0	Keywords:	triaged
Target Milestone:	5.0.0M7
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/95218 https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=cf865e177307774678976d2b0a6bc94dd1f0a647 https://git.eclipse.org/r/95279 https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fc11a14ef7e45da032e2d9c35b2b664ed5b3c3c2
Whiteboard:
Bug Depends on:	513249
Bug Blocks:

Description Pierre-Charles David

2017-03-07 11:02:29 EST

+++ This bug was initially created as a clone of Bug #513249 +++

Properties of elements which can not be edited, e.g. because of insufficient permission (as determined by IPermissionAuthority.canEditInstance) should not only be disabled, but have an explicit decoration to be consistent with the other reasons for read-only (e.g. red lock when LOCKED_BY_OHTER).

Comment 1 Pierre-Charles David

2017-03-07 11:02:56 EST

Clone to report the enhancement on master for Sirius 5.0.0.

Comment 2 Eclipse Genie

2017-04-19 03:59:38 EDT

New Gerrit change created: https://git.eclipse.org/r/95218

Comment 3 Eclipse Genie

2017-04-19 04:20:42 EDT

Gerrit change https://git.eclipse.org/r/95218 was merged to [master].
Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=cf865e177307774678976d2b0a6bc94dd1f0a647

Comment 4 Eclipse Genie

2017-04-19 08:39:37 EDT

New Gerrit change created: https://git.eclipse.org/r/95279

Comment 5 Eclipse Genie

2017-04-19 09:17:21 EDT

Gerrit change https://git.eclipse.org/r/95279 was merged to [master].
Commit: http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=fc11a14ef7e45da032e2d9c35b2b664ed5b3c3c2

Comment 6 Pierre-Charles David

2017-04-20 07:36:00 EDT

Fixed by:
* cf865e177307774678976d2b0a6bc94dd1f0a647 on the EEF side, which adds runtime support for the "grey lock" decoration for read-only elements;
* fc11a14ef7e45da032e2d9c35b2b664ed5b3c3c2 on the Sirius side, which tells EEF about read-only elements based on ModelAccessor.

Comment 7 Laurent Fasani

2017-05-22 08:36:32 EDT

Validated on ODCE_20170521 using a sirius based application to test the grey lock display in model explorer and properties view.

Comment 8 Pierre-Charles David

2017-06-29 03:33:17 EDT

Available in Sirius 5.0.0, see https://wiki.eclipse.org/Sirius/5.0.0 for details.