Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 513248

Summary:	POM Updates Required
Product:	[Eclipse Project] Equinox	Reporter:	Sravan Kumar Lakkimsetti <sravankumarl>
Component:	p2	Assignee:	Markus Keller <markus.kell.r>
Status:	RESOLVED FIXED	QA Contact:
Severity:	trivial
Priority:	P3	CC:	daniel_megert, markus.kell.r, pascal, sravankumarl, tjwatson
Version:	4.7.0 Oxygen
Target Milestone:	Oxygen M6
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/92580 https://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=dec2ef35a315551f719435ee1bd53dfdf6495a48
Whiteboard:
Bug Depends on:	512100
Bug Blocks:

Description Sravan Kumar Lakkimsetti

2017-03-07 10:09:13 EST

Need to update POM versions in p2

see http://download.eclipse.org/eclipse/downloads/drops4/I20170307-0800/pom_updates/

Comment 1 Sravan Kumar Lakkimsetti

2017-03-08 01:06:11 EST

Here is the problem 

bundles/org.eclipse.equinox.p2.tests.reconciler.product/pom.xml has version 4.7.0-SNAPSHOT and

bundles/org.eclipse.equinox.p2.tests.reconciler.product/reconciler.product has version 1.0.0-SNAPSHOT

This was uncovered by latest Tycho's pom-updater-plugin. We are using 1.1.0-SNAPSHOT. 

The change required here is modify reconciler.product. Not to change pom.xml

Comment 2 Eclipse Genie

2017-03-08 01:41:02 EST

New Gerrit change created: https://git.eclipse.org/r/92580

Comment 3 Sravan Kumar Lakkimsetti

2017-03-08 04:03:24 EST

See bug 512100 for movement to Tycho 1.1.0

Comment 4 Sravan Kumar Lakkimsetti

2017-03-08 04:07:49 EST

We missed to update pom-updater-plugin version during the movement to 1.1.0. This has been done yesterday. That uncovered this.

Please review the Gerrit change https://git.eclipse.org/r/92580 and committ it to fix this issue

Comment 5 Eclipse Genie

2017-03-08 05:42:25 EST

Gerrit change https://git.eclipse.org/r/92580 was merged to [master].
Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=dec2ef35a315551f719435ee1bd53dfdf6495a48

Comment 6 Markus Keller

2017-03-08 05:43:07 EST

(In reply to Sravan Kumar Lakkimsetti from comment #1)
> The change required here is modify reconciler.product. Not to change pom.xml

Why should we have to increase the product version just because Maven requires redundant information in their POM file? The POM was broken, so the fix should go there.

Setting the product version to 4.7.0 is a no-go for two reasons:
- There was no breaking change in the product, so we can't increase the major segment.
- A version 4.7.0 anywhere else in a POM would cause trouble each time in the future when we have to update parent POM versions. In Equinox, we do this with a global search/replace because the regex we use in the other repos doesn't work in Equinox.

Fixed the version reference in the POM:
http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=dec2ef35a315551f719435ee1bd53dfdf6495a48