Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 513196

Summary:	DOT Editor - Add Quickfix support for the currently supported DOT attributes.
Product:	[Tools] GEF	Reporter:	Tamas Miklossy <miklossy>
Component:	GEF DOT	Assignee:	gef-inbox <gef-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	unspecified
Target Milestone:	5.1.0 (2019-06)
Hardware:	PC
OS:	Windows NT
Whiteboard:

Description Tamas Miklossy

2017-03-06 14:27:33 EST

The current implementation of the DotQuickfixProvider provides quick fix support only for the Dot style attribute. 

This support should be extended for the other Dot attribute values (at least for attributes with enumeration values or subgrammar definitions).

Comment 1 Tamas Miklossy

2017-03-06 16:32:07 EST

I pushed the following changes to origin/master:

[513196] Implement additional DOT Quickfixes for the attributes values.

- Implement Dot Quickfixes for the arrowhead, arrowtail, clusterrank,
colorscheme, dir, layout, outputorder, pagedir, rankdir and shape
attribute values.
- Modify the DotStyleJavaValidator and the DotArrowTypeJavaValidator to
pass the necessary information (as issueData) to the DotQuickfixProvider.
- Implement corresponding Dot Quickfixes test cases.

Comment 2 Tamas Miklossy

2018-10-20 07:08:25 EDT

I pushed the following changes to origin/master:

[513196] DOT Editor - add Quickfixes for invalid edge operator errors.

- Modify the DotQuickfixProvider to provide quickfixes for issues with
the INVALID_EDGE_OPERATOR issue code.
- Implement corresponding DotQuickfixTests test cases.

Comment 3 Tamas Miklossy

2019-02-09 08:38:51 EST

I pushed the following changes to the master branch:

[513196] Improve the DOT Editor Quickfix support.

Modify the DotQuicfixProvider to provide qickfixes for;
- invalid multiple arrowhead/arrowtail attribute values
- invalid multiple arrowtail attribute values
- invalid multiple style attribute values
- redundant multiple style attribute values
- deprecated style attribute values

Implement corresponding DotQuickfixTests test cases.

Comment 4 Tamas Miklossy

2019-02-17 05:29:28 EST

I pushed the following changes to origin/master:

[513196] Improve the DOT Editor Quickfix support.

- Modify the DotQuickfixProvider to use the delete icon from jdt
(instead of the default icon) when removing redundant attributes and
duplicated style items.

Comment 5 Tamas Miklossy

2019-03-01 06:08:34 EST

I pushed the following changes to the master branch:

[513196] Improve Quickfixing the 'arrowhead'/'arrowtail' DOT attributes.

- Modify the DotQuickfixProvider to provide quickfixes when using
invalid modifiers (open, left, right) in the 'arrowhead'/'arrowtail' DOT
attribute values.
- Modify the DotArrowTypeJavaValidator to provide the necessary issue
Data that will be evaluted by the quickfixes.
- Implement corresponding DotQuickfixTests test cases.

Comment 6 Tamas Miklossy

2019-03-01 09:00:55 EST

I pushed the following changes to the master branch:

[513196] DOT Editor - Add Quickfix for the supported DOT attributes.

- Modify the DotQuickfixProvider to provide quickfixes for invalid
'arrowhead'/'arrowtail' attribute values if the 'none' arrowshape is the
last arrowshape.

- Implement corresponding DotQuickfixTests test cases.

Comment 7 Tamas Miklossy

2019-03-16 03:28:58 EDT

I resolve this issue as fixed in 5.1.0 (2019-06).