Bugzilla – Full Text Bug Listing
| Summary: | GTK: MenuDetect issues with toolbar | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Thomas Singer <eclipse> | ||||
| Component: | SWT | Assignee: | Alexander Kurtakov <akurtakov> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | akurtakov, ericwill, loskutov | ||||
| Version: | 4.7 | Keywords: | triaged | ||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/93503 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8bd9620059daff78087c993d22fdbe714fe2d2ac https://git.eclipse.org/r/112484 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=056a3d562f2f340d63370d8408fc17e81209a712 https://git.eclipse.org/r/112512 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5a6656cb7a403b102a129c5017dc01e479e1ccda |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | 527860 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Thomas Singer
Created attachment 267109 [details]
Code sample
New Gerrit change created: https://git.eclipse.org/r/93503 Gerrit change https://git.eclipse.org/r/93503 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=8bd9620059daff78087c993d22fdbe714fe2d2ac (In reply to Eclipse Genie from comment #3) > Gerrit change https://git.eclipse.org/r/93503 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=8bd9620059daff78087c993d22fdbe714fe2d2ac Double "Menu detected" fixed. Separator issue needs more investigating. @Thomas: was this issue a *regression* in 4.7, or was this always like this on GTK3 SWT? I'm asking to understand better if the partial fix can be reverted, because it caused a severe regression in bug 527860. (In reply to Andrey Loskutov from comment #5) > @Thomas: was this issue a *regression* in 4.7, or was this always like this > on GTK3 SWT? I don't know, because of the large number of GTK3 problems we did not use it a long time. Because the multiple issues with the GTK toolbar we wrote our own self-painted one for SmartGit. New Gerrit change created: https://git.eclipse.org/r/112484 Gerrit change https://git.eclipse.org/r/112484 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=056a3d562f2f340d63370d8408fc17e81209a712 New Gerrit change created: https://git.eclipse.org/r/112512 Thomas, can you create a junit test for this issue? We need these issues catched by tests as otherwise there is always smth to miss. Gerrit change https://git.eclipse.org/r/112512 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5a6656cb7a403b102a129c5017dc01e479e1ccda Gerrit change https://git.eclipse.org/r/112512 was merged to [R4_7_maintenance]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=5a6656cb7a403b102a129c5017dc01e479e1ccda Is there anything left to be done here? |