Bugzilla – Full Text Bug Listing
| Summary: | Close tabs on right should also be available for the last tab if the chevron is visible | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||
| Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | daniel_megert, gautier.desaintmartinlacaze, Lars.Vogel, loskutov | ||||
| Version: | 4.6 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | stalebug | ||||||
| Bug Depends on: | 337588 | ||||||
| Bug Blocks: | |||||||
| Attachments: |
|
||||||
|
Description
Lars Vogel
Andrey, something for you? Please set a target milestone again when you plan to fix the bug. Andrey, you implemented the menu. Are you interested in fixing this one? (In reply to Lars Vogel from comment #3) > Andrey, you implemented the menu. Are you interested in fixing this one? In theory yes, but it is a very low prio for me now. We've just moved to 4.7.x and the amount of regressions compared to 3.8.2 (especially due GTK3 vs GTK2) does not allow me to work on features. I'm mostly in a permanent firefighter mode :-( (In reply to Andrey Loskutov from comment #4) > (In reply to Lars Vogel from comment #3) > does not allow me to work on features. > I'm mostly in a permanent firefighter mode :-( Understandable that you have to make priority calls. Just for clarification, current behavior is IMHO a bug (so this bug is not a feature request). (In reply to Lars Vogel from comment #5) > current behavior is IMHO a bug (so this bug is not a feature request). No, this is by design (not judging whether it's good or bad ;-). When there are hidden editors (chevron visible) and one invokes 'Close Tabs to the Right', it only closes the editors that are visible via its tab. The hidden ones are not close. That explains why the menu is not available on the rightmost editor tab. So, either this bug should be closed or one must also change the current behavior when fixing this one. (In reply to Dani Megert from comment #6) > No, this is by design (not judging whether it's good or bad ;-). How do you know the design behind it? IIRC it was Andrey implementing it and I did the review of this contribution. (In reply to Lars Vogel from comment #7) > (In reply to Dani Megert from comment #6) > > > No, this is by design (not judging whether it's good or bad ;-). > > How do you know the design behind it? IIRC it was Andrey implementing it and > I did the review of this contribution. Let's say it that way: close tabs to the right does not close hidden editors. This is currently true and hence it makes sense not to show the menu. Adding the menu and close the hidden ones would be strange. Having said that, Firefox closes hidden editors. (In reply to Dani Megert from comment #8) > Adding the menu and close the hidden ones would be strange. I mean, if we'd only close the hidden ones when invoked from the rightmost tab. > (In reply to Dani Megert from comment #8)
The current behavior is an oversight/error of our implementation and definitely not a design choice (at least from my side). If I would have found that during the initial review, it would have been implemented differently.
(In reply to Lars Vogel from comment #10) > > (In reply to Dani Megert from comment #8) > > The current behavior is an oversight/error of our implementation and > definitely not a design choice (at least from my side). If I would have > found that during the initial review, it would have been implemented > differently. Yep. I've just assumed all this e4 containers etc include tabs shown in the chevron too, and I just did not noticed that this is not the case. So this is a bug, not a design decision. However the problem here is that chevron contains not only "tabs to the right". It contains hidden tabs, which may be to the left, to the right or, in MRU case, *somewhere*, because MRU shuffles tabs every time you touch them. So I guess this request will not work for MRU anyway. Currently it behaves consistently by not closing any hidden stuff, so, I would close this as WORKSFORME (or WONTFIX). (In reply to Dani Megert from comment #12) > Currently it behaves consistently by not closing any hidden stuff, so, I > would close this as WORKSFORME (or WONTFIX). Both person which were involved in the original implentation say its a bug and you suggest to close it as WONTFIX? I believe in MRU case ALL hidden tabs are "on the right side". (In reply to Lars Vogel from comment #13) > (In reply to Dani Megert from comment #12) > > Currently it behaves consistently by not closing any hidden stuff, so, I > > would close this as WORKSFORME (or WONTFIX). > > Both person which were involved in the original implentation say its a bug > and you suggest to close it as WONTFIX? Yes. To repeat: the command does not close any editors hidden by the chevron. Doing this only for the rightmost one would be worse than what we have now. So, just closing those that are visible as we do now, is a good solution for the user. I would accept a fix that closes all editors on the right when invoked from any tab, but only doing it for the rightmost one would be a -2 from me. (In reply to Dani Megert from comment #15) > I would accept a fix that closes all editors on the right when invoked from > any tab, but only doing it for the rightmost one would be a -2 from me. OK, sounds like we had a misunderstanding between us. Of course that is the correct fix for this bug. Anything else would be nonsense. (In reply to Lars Vogel from comment #16) > (In reply to Dani Megert from comment #15) > > > I would accept a fix that closes all editors on the right when invoked from > > any tab, but only doing it for the rightmost one would be a -2 from me. > > OK, sounds like we had a misunderstanding between us. Of course that is the > correct fix for this bug. Anything else would be nonsense. :-) New Gerrit change created: https://git.eclipse.org/r/121470 Gerrit change https://git.eclipse.org/r/121470 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=7b5edb05b3900a6e9586643530f4c31776371e2a This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet. As such, we're closing this bug. If you have further information on the current state of the bug, please add it and reopen this bug. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant. -- The automated Eclipse Genie. |