Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 513044

Summary:	Git page spins forever if the remote cannot be resolved
Product:	[ECD] Orion	Reporter:	Remy Suen <remy.suen>
Component:	Git	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P3	CC:	Silenio_Quarti
Version:	13.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 10
Whiteboard:

Description Remy Suen

2017-03-03 04:51:09 EST

orion.eclipse.org

1. File > Project > Git Repository > https://github.com/octocat/Spoon-Knife.git
2. Select the new project > Context menu > Open Related > Git Repository
3. Click the 'Configurations' wrench tool item in the top right corner.
4. Select 'remote.origin.url' > Click on the pencil icon to edit it
5. Enter in something ridiculous > https://nonexistentoriontest.com > Submit
6. Reload the page. You will now be spinning forever. :(

This bug was caused by some "WebIDE fix". There is no associated Eclipse bug.

https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=41f48987e99bc1e2ca69166591b2f699bce46cd3

This regression breaks...
1. offline support (I depend on this at work though probably important to no one else, lol...)
2. server outage support (if your Git remotes cannot be resolved, you cannot use Git with Orion)

We need to handle errors better in Git. We currently flag all non-authentication related errors as a 403. This is wrong. If we can't resolve a remote then we should use a 503 (or maybe a 404?).

https://github.com/eclipse/orion.client/blob/e10609e58dc278f8f7e9d00643c10f5890d7a3da/modules/orionode/lib/git/clone.js#L545

Comment 1 Silenio Quarti

2017-03-03 10:51:12 EST

I have reverted the change that caused the problem.