Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 512972

Summary: TypeError preventing me from resetting to a commit in history
Product: [ECD] Orion Reporter: Curtis Windatt <curtis.windatt.public>
Component: GitAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED DUPLICATE QA Contact:
Severity: major    
Priority: P2 CC: Carolyn_MacLeod, remy.suen, snorthov
Version: 13.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Curtis Windatt CLA 2017-03-02 09:59:50 EST
1) Have local commits
2) See that there are new commits on the remote
3) I want to reset my branch to the last commit in shared history
4) Navigate to the commit and hit the counter clockwise arrow to reset
Result:
Nothing happens

In the console:
parameterCollectors.js:143 Uncaught TypeError: Cannot read property 'trim' of undefined
    at isValid (http://client.orion.eclipse.org:9000/orion/parameterCollectors.js:143:52)
    at Array.some (native)
    at CommandParameterCollector._collectAndCall (http://client.orion.eclipse.org:9000/orion/parameterCollectors.js:162:35)
    at finish (http://client.orion.eclipse.org:9000/orion/parameterCollectors.js:327:20)
    at HTMLButtonElement.<anonymous> (http://client.orion.eclipse.org:9000/orion/parameterCollectors.js:344:6)
Comment 1 Curtis Windatt CLA 2017-03-02 10:00:36 EST
Saw this in orion.eclipse.org, but reproduced in self host to get the stack trace.
Comment 2 Curtis Windatt CLA 2017-03-02 10:12:26 EST
Probably related to changes in Bug 502409.
Comment 3 Steve Northover CLA 2017-03-29 11:58:22 EDT
Curtis, please fix right away or revert the change that caused the problem.  We should not leave known bugs that were caused by specific code changes that don't have direct owners who can address them quickly.
Comment 4 Carolyn MacLeod CLA 2017-03-29 12:09:08 EDT
I think this is a dup of bug 513012 comment 1 ?
Comment 5 Steve Northover CLA 2017-03-29 12:12:57 EDT
Is the bug fixed or not?  If fixed close, if not fixed revert code that caused it or fix.
Comment 6 Carolyn MacLeod CLA 2017-03-29 12:25:20 EDT
Should be fixed. Curtis, can you please confirm? Thx!
Comment 7 Curtis Windatt CLA 2017-03-29 13:21:56 EDT
This is fixed by commit in Bug 513012

*** This bug has been marked as a duplicate of bug 513012 ***