Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 512868

Summary:	Default rules are ignoring/pruning some elements in Ecore from the UI
Product:	[Modeling] Sirius	Reporter:	Cedric Brun <cedric.brun>
Component:	Properties	Assignee:	Project Inbox <sirius.properties-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	pierre-charles.david, steve.monnier
Version:	4.1.1	Keywords:	triaged
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/92077 https://git.eclipse.org/c/ecoretools/org.eclipse.ecoretools.git/commit/?id=a5c96e35aeba2363497a09b5a797ac19bd333bb7
Whiteboard:

Description Cedric Brun

2017-03-01 04:47:26 EST

Steps to reproduce:
- install Sirius with the property views support, I just unzipped "OD CE 9.1.1"
- create a new Ecore modeling project with a class diagram
- create an EClass, add an EAttribute and click on it to edit it through the property view
- click on the "Main" tab
- click on the "..." to set the EType of the EAttribute
=> you can't pick any of the Ecore types

That tab is the first visible, that makes the whole scenario fairly confusing to end users. 

We might want to disable this default rules for EcoreTools altogether in the meantime, what do you think ?

Comment 1 Eclipse Genie

2017-03-01 08:07:57 EST

New Gerrit change created: https://git.eclipse.org/r/92077

Comment 2 Cedric Brun

2017-03-01 08:09:16 EST

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/92077

I'll disable the default rules in the context of EcoreTools so that the problem is worked-around starting from Neon.3

Comment 3 Cedric Brun

2017-03-01 08:09:24 EST

(In reply to Eclipse Genie from comment #1)
> New Gerrit change created: https://git.eclipse.org/r/92077

I'll disable the default rules in the context of EcoreTools so that the problem is worked-around starting from Neon.3

Comment 4 Eclipse Genie

2017-03-01 08:17:11 EST

Gerrit change https://git.eclipse.org/r/92077 was merged to [master].
Commit: http://git.eclipse.org/c/ecoretools/org.eclipse.ecoretools.git/commit/?id=a5c96e35aeba2363497a09b5a797ac19bd333bb7

Comment 5 Cedric Brun

2017-04-27 11:24:16 EDT

Digging further: It seems that the method : 


  private void initializeInput() {
        this.eObjectTreeViewer.setInput(this.editingContextAdapter.getEditingDomain().getResourceSet());
    }

in EEFExtEObjectSelectionPage means anything outside the resourceset will not be selectable. 

I'm still wondering what is the best option here. In ecore tools we might need to select EDatatypes from Ecore.ecore (which is not in the resourceset)

Comment 6 Cedric Brun

2017-05-05 05:50:07 EDT

For the record: I worked-around this bug by using another widget: a Label+button trigerring a  SelectModelElement wizard.

This is more convenient for the end user anyway...

Considering this bug only happens if one has to rely on a resource which is not part of the resourceset (or have no resource) which is a situation which is not really supposed to work anyway I'm not sure this is very worthy to fix.

Comment 7 Pierre-Charles David

2017-05-18 05:58:54 EDT

This was highly specific to the Ecore Tools case, and Cédric used a different (and better) approach, so closing as WONTFIX.