Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 512847

Summary:	Race condition getting computed environment
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Michael Rennie <Michael_Rennie>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2	CC:	curtis.windatt.public
Version:	13.0	Flags:	curtis.windatt.public: review+
Target Milestone:	14.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2017-02-28 16:58:01 EST

It can happen that linting takes place before the project context has been fully computed. This results in some false positive lint warnings that would normally not be reported if the project context was fully known.

Comment 1 Michael Rennie

2017-02-28 16:59:26 EST

Fixed in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6a1966b2b88ae9febfbf67c9b6e78a3f18a0dabb

Comment 2 Michael Rennie

2017-02-28 17:29:25 EST

Clicking between projects really quickly, I could produce the race condition still. Reopening.

Comment 3 Michael Rennie

2017-03-02 09:57:06 EST

Pushed updated fix to: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=2bf1ab574d900f603f6e6a0891b11e31b04a57a7

Curtis, please verify.

Comment 4 Curtis Windatt

2017-03-02 10:27:07 EST

I can still reproduce the race condition using back/forward buttons. Works when navigating.

Comment 5 Curtis Windatt

2017-03-02 11:05:30 EST

(In reply to Curtis Windatt from comment #4)
> I can still reproduce the race condition using back/forward buttons. Works
> when navigating.

Shenanigans! After reloading the page I can't reproduce at all.  Even when forcing delays in the project context loading. I had just run into a problem on the Git page, so perhaps I didn't have the latest piece of the fix until a reload with the dev tools open to disable the cache.

+1 for 14.0.

Comment 6 Michael Rennie

2017-03-02 12:50:55 EST

Closing fixed, thanks Curtis