Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 512798

Summary: URI error when deleting tag with special encoding
Product: [ECD] Orion Reporter: Remy Suen <remy.suen>
Component: GitAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 13.0   
Target Milestone: 14.0   
Hardware: All   
OS: All   
Whiteboard:

Description Remy Suen CLA 2017-02-28 05:02:26 EST 
1. Open the 'Git' page.
2. Create an annotated tag on a commit.
3. Name it > a%b
4. Click the 'X' marker to try to delete it.
5. You'll get a red failure at the bottom stating "Problem while performing the action".
6. Repeat steps 2-5 for a lightweight tag (not annotated). You'll get the same error.

URIError: URI malformed
    at decodeURIComponent (native)
    at Object.module.exports.decodeURIComponent (orion.client\modules\orionode\lib\git\util.js:20:9)
    at deleteTag (orion.client\modules\orionode\lib\git\tags.js:198:21)
    at Layer.handle [as handle_request] (orion.client\modules\orionode\node_modules\express\lib\router\layer.js:95:5)
    at next (orion.client\modules\orionode\node_modules\express\lib\router\route.js:131:13)
    at Route.dispatch (orion.client\modules\orionode\node_modules\express\lib\router\route.js:112:3)
    at Layer.handle [as handle_request] (orion.client\modules\orionode\node_modules\express\lib\router\layer.js:95:5)
    at orion.client\modules\orionode\node_modules\express\lib\router\index.js:277:22
    at param (orion.client\modules\orionode\node_modules\express\lib\router\index.js:349:14)
    at param (orion.client\modules\orionode\node_modules\express\lib\router\index.js:365:14)
    at param (orion.client\modules\orionode\node_modules\express\lib\router\index.js:365:14)
    at Function.process_params (orion.client\modules\orionode\node_modules\express\lib\router\index.js:410:3)
    at next (orion.client\modules\orionode\node_modules\express\lib\router\index.js:271:10)
    at orion.client\modules\orionode\node_modules\body-parser\lib\read.js:129:5
    at invokeCallback (orion.client\modules\orionode\node_modules\raw-body\index.js:262:16)
    at done (orion.client\modules\orionode\node_modules\raw-body\index.js:251:7)