Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 512387

Summary:	[Properties] UML Advanced Properties assumes too much about adaptables
Product:	[Modeling] Papyrus	Reporter:	Christian Damus <give.a.damus>
Component:	Views	Assignee:	Christian Damus <give.a.damus>
Status:	RESOLVED FIXED	QA Contact:
Severity:	critical
Priority:	P1	CC:	rschnekenburger
Version:	2.0.2
Target Milestone:	3.0.0
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/91415 https://git.eclipse.org/r/91416 https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=63877606e3175acca5bbcb42ba850b5cae1f32c1 https://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=4db9d8ca8c560a14c17c5e7d3c9566c722e98821
Whiteboard:	blockingpapyrusrt
Bug Depends on:
Bug Blocks:	510315

Description Christian Damus

2017-02-17 17:11:06 EST

The Advanced tab for UML elements transforms the incoming selection from a diagram with too many assumptions about objects that actually are adaptable.

The UMLPropertySection::transformSelection(Object) method doesn't attempt to object EObject adapters from IAdaptables except as a last resort, when the usual pattern in Papyrus is to attempt this adaptation first.  In particular, the handling of EditParts by obtaining the semantic element directly from the notation view doesn't account for special edit-part semantic adaptation as in Papyrus-RT, where the view references the root definition of elements that are inherited.

Consequently, for inherited elements in Papyrus-RT, the Advanced properties shows the properties of the wrong element, so that any redefinition is not apparent.  It is difficult or impossible for Papyrus-RT to replace the Advanced properties contribution of the Papyrus UML Diagram Common layer, so this misadaptation needs to be fixed in Papyrus.

Comment 1 Eclipse Genie

2017-02-17 17:16:21 EST

New Gerrit change created: https://git.eclipse.org/r/91415

Comment 2 Eclipse Genie

2017-02-17 17:19:13 EST

New Gerrit change created: https://git.eclipse.org/r/91416

Comment 3 Eclipse Genie

2017-02-17 17:56:41 EST

Gerrit change https://git.eclipse.org/r/91415 was merged to [streams/2.0-maintenance].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=63877606e3175acca5bbcb42ba850b5cae1f32c1

Comment 4 Eclipse Genie

2017-02-17 18:39:48 EST

Gerrit change https://git.eclipse.org/r/91416 was merged to [master].
Commit: http://git.eclipse.org/c/papyrus/org.eclipse.papyrus.git/commit/?id=4db9d8ca8c560a14c17c5e7d3c9566c722e98821

Comment 5 Christian Damus

2017-02-17 18:40:46 EST

(In reply to Eclipse Genie from comment #3)
> Gerrit change https://git.eclipse.org/r/91415 was merged to
> [streams/2.0-maintenance].

(In reply to Eclipse Genie from comment #4)
> Gerrit change https://git.eclipse.org/r/91416 was merged to [master].