Bugzilla – Full Text Bug Listing
| Summary: | orion.eclipse.org crashed in nodegit | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Silenio Quarti <Silenio_Quarti> | ||||
| Component: | Node | Assignee: | Remy Suen <remy.suen> | ||||
| Status: | RESOLVED NOT_ECLIPSE | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | Michael_Rennie, remy.suen, snorthov | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 514343 | ||||||
| Attachments: |
|
||||||
There was a crash last year also. The log looks quite similar to bug 500531. The generated code in NodeGit is very obviously wrong as it is indeed performing a double free. However, from speaking to the libgit2 team, the code path to lead to a double free call is not exactly simple. "but this is still pretty hard to make fail, it's supposed to handle errors gracefully" "making malloc fail would certainly make it unhappy" I feel like if malloc is dying then we're kind of doomed to die anyway since at that point we're either out of memory or the OS has gone haywire, so... I have collected my findings and submitted an issue to GitHub. https://github.com/nodegit/nodegit/issues/1226 *** Bug 500531 has been marked as a duplicate of this bug. *** |
Created attachment 266874 [details] log