Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 512286

Summary: Support SVG in CSS tooling
Product: [ECD] Orion Reporter: Steve Northover <steve_northover>
Component: JS ToolsAssignee: Curtis Windatt <curtis.windatt.public>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P2 CC: curtis.windatt.public
Version: unspecified   
Target Milestone: 14.0   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Steve Northover CLA 2017-02-16 08:34:27 EST
What are the errors here?  Are they real?

#globe-gradient .start-color {
  stop-color: red;
}

#globe-gradient .end-color {
  stop-color: blue;
}

.globe {
    stroke: #006600;
    fill: url(#globe-gradient);
}
Comment 1 Curtis Windatt CLA 2017-02-16 09:42:54 EST
Do you have errors?  I only have info annotations.
stop-color is used in SVG which we don't have support for in the CSSLint tools

SVG is an official spec for HTML5, so I'm changing this bug to look at supporting it.  However CSSLint does not yet support it and parser-lib only partially supports it.

https://github.com/CSSLint/parser-lib/issues/28
https://github.com/CSSLint/csslint/issues/283
Comment 2 Steve Northover CLA 2017-02-16 09:54:44 EST
Other editors do not show warnings etc.
Comment 3 Steve Northover CLA 2017-02-16 11:30:03 EST
As discussed on a call, a summary of what we can do, how much work and then we change the priority.  If we could indicate somehow that svg is not yet supported that would be ok too.
Comment 4 Curtis Windatt CLA 2017-02-16 16:28:39 EST
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ec304672bd05f96b08c0c13c6cf529ac6cc5251a
Fixed in master with tests

I added all the SVG CSS properties to our csslint parser-lib so we won't complain about unknown properties. Long term we should look at updating CSSLint to take in all the property changes done in the last 2 years, see Bug 508847.

This will not remove the info annotation for using ID in a selector. This is still the default behaviour of CSSLint and you will see it anywhere you use a CSSLint plugin (brackets, etc.). There is some debate over whether this particular rule is correct.