Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 511824

Summary: All tags are flagged as being lightweight
Product: [ECD] Orion Reporter: Remy Suen <remy.suen>
Component: GitAssignee: Remy Suen <remy.suen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 13.0   
Target Milestone: 14.0   
Hardware: All   
OS: All   
Whiteboard:

Description Remy Suen CLA 2017-02-07 05:49:34 EST
Git supports lightweight and annotated tags. We should not be flagging all tags as being lightweight.

https://github.com/eclipse/orion.client/blob/576562ad9ac037d4822c1c5d5401a27b1748dc4d/modules/orionode/lib/git/tags.js#L44
Comment 1 Remy Suen CLA 2017-02-07 06:26:47 EST
First pass delivered to master. This adds support for the GET case where all the tags should be returned to the client.

https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=a0136ae43bb6dd4876323de72d1afeaa8bb2b943
Comment 2 Remy Suen CLA 2017-02-07 07:16:50 EST
Second pass delivered to master which adds support for GET requests for individual tags. All that's left is to fix commits.js.

https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6882a9d30335449659a3fa2989a01dc3a0f517d1
Comment 3 Remy Suen CLA 2017-02-08 04:19:15 EST
Final pass which fixes commit.js has been pushed to master.

https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6227422a4c4fe9dfd41d335fb8e9398a1fdffa74