Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 511315

Summary:	[regression] We need to add back support for tagging module names to resolved files in Tern
Product:	[ECD] Orion	Reporter:	Michael Rennie <Michael_Rennie>
Component:	JS Tools	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P2
Version:	13.0
Target Milestone:	14.0
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Michael Rennie

2017-01-30 10:08:35 EST

As part of the changes to make a resolver plugin for requirejs, we seem to have lost the ability to tag resolved modules with the name Tern was looking for. This causes our unknown-require linting rule to mistakenly flag modules as not found, when they have indeed been found.

Comment 1 Michael Rennie

2017-01-30 10:19:52 EST

I pushed a partial fix in:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=bc0c9f18aafaccb694c114390a2e31fbc267e74a

It needs more debugging to make sure we tag modules all the time, and to make sure that the unknown-require rule is properly working again.

Comment 2 Curtis Windatt

2017-01-30 16:16:45 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=0bcc2f4f867fdd5e3ae5c315ff14767e0b6d7aa5
Fixed in master with new validator test suite that runs node plugin

Mike can you sanity check the rule behaviour now?  In server.js for example we only put warnings on socket.io and electron which aren't in our default libraries.