Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 511239

Summary:	Remove top level this uses
Product:	[ECD] Orion	Reporter:	Alston Lin <alston>
Component:	Client	Assignee:	Alston Lin <alston>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	unspecified
Target Milestone:	15.0
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/89778 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d3254ca95bd8279c54d0ef74f66acd4f385d549a
Whiteboard:

Description Alston Lin

2017-01-27 14:52:01 EST

There are instances of usage of top-level "this" (which is the global object) in these files:
bundles/org.eclipse.orion.client.ui/web/edit/setup.js
bundles/org.eclipse.orion.client.editor/web/orion/editor/edit.js

This would break the webpack migration, as it violates strict mode

Comment 1 Eclipse Genie

2017-01-27 15:35:40 EST

New Gerrit change created: https://git.eclipse.org/r/89778

Comment 2 Eclipse Genie

2017-01-31 12:28:04 EST

Gerrit change https://git.eclipse.org/r/89778 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d3254ca95bd8279c54d0ef74f66acd4f385d549a

Comment 3 Silenio Quarti

2017-03-24 16:01:18 EDT

Fixed