Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 511237

Summary:	Improper uses of arguments.callee
Product:	[ECD] Orion	Reporter:	Alston Lin <alston>
Component:	Client	Assignee:	Alston Lin <alston>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Silenio_Quarti
Version:	unspecified
Target Milestone:	15.0
Hardware:	PC
OS:	Mac OS X
See Also:	https://git.eclipse.org/r/89777 https://git.eclipse.org/r/89905 https://git.eclipse.org/r/89908 https://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fa6fd2580d154fe9c6af070c7d82f4b9096d0ce1
Whiteboard:

Description Alston Lin

2017-01-27 14:50:01 EST

As part of the migration to webpack, which will put all functions in strict mode, we can no longer have arguments.callee in the code.

Uses of arguments.callee need to be removed in the following files

bundles/org.eclipse.orion.client.cf/web/cfui/plugins/cFDeployService.js
bundles/org.eclipse.orion.client.core/web/orion/projectClient.js
bundles/org.eclipse.orion.client.git/web/orion/git/gitCommands.js
bundles/org.eclipse.orion.client.git/web/orion/git/widgets/gitBranchList.js
bundles/org.eclipse.orion.client.ui/web/orion/projectCommands.js

Comment 1 Eclipse Genie

2017-01-27 15:29:35 EST

New Gerrit change created: https://git.eclipse.org/r/89777

Comment 2 Eclipse Genie

2017-01-30 14:58:06 EST

New Gerrit change created: https://git.eclipse.org/r/89905

Comment 3 Eclipse Genie

2017-01-30 15:15:59 EST

New Gerrit change created: https://git.eclipse.org/r/89908

Comment 4 Eclipse Genie

2017-02-09 10:20:44 EST

Gerrit change https://git.eclipse.org/r/89777 was merged to [master].
Commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=fa6fd2580d154fe9c6af070c7d82f4b9096d0ce1

Comment 5 Silenio Quarti

2017-03-24 16:00:53 EDT

Fixed